fix: address CodeRabbit review feedback

- Ack lead messages after returning them in wait_for_team
- Add shebang preservation to build step
- Clamp progress bar and column widths for narrow terminals
- Reset sender grouping at date boundaries in messages
- Fix allTasks order to match rendered column order
- Guard selectedIdx against empty task list
- Fix 'waiting for tasks' condition to check totalAssigned
- Exit with code 1 on TUI errors
- Fix g/G keybindings to match vim convention

Author: Joao208

packages/agent-teams-lead/src/store.ts

@@ -281,6 +281,18 @@ export class TeamStore {
     return this.artifacts.find((a) => a.id === artifactId);
   }
 
+  async ackMessages(readerId: string, messageIds: string[]): Promise<void> {
+    return withFileLock(this.messagesPath(), async () => {
+      this.messages = await this.readJson<Message[]>(this.messagesPath(), []);
+      for (const msg of this.messages) {
+        if (messageIds.includes(msg.id) && !msg.read_by.includes(readerId)) {
+          msg.read_by.push(readerId);
+        }
+      }
+      await this.writeJson(this.messagesPath(), this.messages);
+    });
+  }
+
   getArtifacts(): Artifact[] {
     return [...this.artifacts];
   }

packages/agent-teams-lead/src/tools.ts

@@ -215,6 +215,10 @@ export class LeadTools {
             unread_by: "lead",
           });
 
+          if (leadMessages.length > 0) {
+            await this.store.ackMessages("lead", leadMessages.map((m) => m.id));
+          }
+
           return this.ok({
             done: true,
             reason:
@@ -251,6 +255,11 @@ export class LeadTools {
         to: "lead",
         unread_by: "lead",
       });
+
+      if (leadMessagesOnTimeout.length > 0) {
+        await this.store.ackMessages("lead", leadMessagesOnTimeout.map((m) => m.id));
+      }
+
       return this.ok({
         done: false,
         timed_out: true,

packages/agent-teams-ui/package.json

@@ -8,7 +8,7 @@
     "agent-teams-ui": "./dist/index.js"
   },
   "scripts": {
-    "build": "tsc",
+    "build": "tsc && echo '#!/usr/bin/env node' | cat - dist/index.js > dist/index.js.tmp && mv dist/index.js.tmp dist/index.js",
     "dev": "tsx src/index.tsx",
     "start": "node dist/index.js"
   },

packages/agent-teams-ui/src/components/ChatView.tsx

@@ -80,8 +80,8 @@ export function ChatView({ lines }: Props) {
     if (key.downArrow || input === "j") {
       setScrollOffset((o) => Math.max(0, o - 3));
     }
-    if (input === "g") setScrollOffset(Math.max(0, filtered.length - viewHeight));
-    if (input === "G") setScrollOffset(0);
+    if (input === "g") setScrollOffset(0);
+    if (input === "G") setScrollOffset(Math.max(0, filtered.length - viewHeight));
   });
 
   const agentColors = new Map<string, string>();

packages/agent-teams-ui/src/components/MessagesView.tsx

@@ -72,7 +72,7 @@ export function MessagesView({ messages }: Props) {
         const date = formatDate(msg.created_at);
         const showDate = date !== lastDate;
         lastDate = date;
-        const showName = msg.from_name !== lastFrom;
+        const showName = msg.from_name !== lastFrom || showDate;
         lastFrom = msg.from_name;
 
         const target =

packages/agent-teams-ui/src/components/TasksView.tsx

@@ -87,15 +87,15 @@ function TaskDetail({ task, nameMap }: { task: Task; nameMap: Map<string, string
 export function TasksView({ tasks, teammates }: Props) {
   const { stdout } = useStdout();
   const totalWidth = Math.min(stdout?.columns || 80, 120);
-  const colWidth = Math.floor((totalWidth - COLUMNS.length - 1) / COLUMNS.length);
+  const colWidth = Math.max(10, Math.floor((totalWidth - COLUMNS.length - 1) / COLUMNS.length));
   const nameMap = new Map(teammates.map((t) => [t.id, t.name]));
 
   const [selectedIdx, setSelectedIdx] = useState(0);
   const [detailTask, setDetailTask] = useState<Task | null>(null);
 
   const allTasks = [
-    ...tasks.filter((t) => t.status === "in_progress"),
     ...tasks.filter((t) => t.status === "pending"),
+    ...tasks.filter((t) => t.status === "in_progress"),
     ...tasks.filter((t) => t.status === "blocked"),
     ...tasks.filter((t) => t.status === "completed"),
   ];
@@ -109,7 +109,7 @@ export function TasksView({ tasks, teammates }: Props) {
       setSelectedIdx((i) => Math.max(0, i - 1));
     }
     if (key.downArrow || input === "j") {
-      setSelectedIdx((i) => Math.min(allTasks.length - 1, i + 1));
+      setSelectedIdx((i) => Math.min(Math.max(0, allTasks.length - 1), i + 1));
     }
     if (key.return && allTasks[selectedIdx]) {
       setDetailTask(allTasks[selectedIdx]);

packages/agent-teams-ui/src/components/TeamView.tsx

@@ -59,7 +59,7 @@ export function TeamView({ team, tasks }: Props) {
                 <Text color={colors.brand}>{symbols.check} all tasks done</Text>
               </Box>
             )}
-            {!current && doneCount === 0 && (
+            {!current && doneCount === 0 && totalAssigned === 0 && (
               <Box paddingLeft={3}>
                 <Text color={colors.muted}>waiting for tasks</Text>
               </Box>

packages/agent-teams-ui/src/index.tsx

@@ -8,4 +8,7 @@ const workspacePath = resolve(process.argv[2] || process.cwd());
 
 const { waitUntilExit } = render(<App workspacePath={workspacePath} />);
 
-waitUntilExit().catch(() => process.exit(0));
+waitUntilExit().catch((err) => {
+  if (err) process.stderr.write(String(err) + "\n");
+  process.exit(1);
+});