fix(formatting): resolve ANSI text effects into actual effects

The API change in cursive-core 0.4.0 included the addition of EffectStatus,
which was intended to allow composite or additive effects, as well as exclusive
effects. The recent update to misapplied this new API and ignored the status,
effectively applying all styles, all the time. This change instead resolves the
incoming styles against an "empty" style, yielding only the styles that should
be applied. As far as I am aware, we don't do any compositing with cursive
styles, so this should yield same results as we had with cursive 0.3.

Moreover, because we're once again only iterating on the actual effects we need
to apply, we can also restore the `bail!()` that was unnecessarily removed
durint the upgrade.

Closes #1642

Ref: ed946a9
Ref: f6a7008
Ref: gyscos/cursive@ea2e0be

Author: claytonrcarter

git-branchless-lib/src/core/formatting.rs

@@ -6,7 +6,7 @@
 
 use std::fmt::Display;
 
-use cursive::theme::{Effect, Style};
+use cursive::theme::{ConcreteEffects, Effect, Style};
 use cursive::utils::markup::StyledString;
 use cursive::utils::span::Span;
 
@@ -404,14 +404,14 @@ fn render_style_as_ansi(content: &str, style: Style) -> eyre::Result<String> {
 
     let output = {
         let mut output = output;
-        for (effect, _status) in effects.statuses.iter() {
+        for effect in effects.resolve(ConcreteEffects::empty()) {
             output = match effect {
                 Effect::Simple => output,
                 Effect::Dim => output.dim(),
                 Effect::Reverse => output.reverse(),
                 Effect::Bold => output.bold(),
                 Effect::Italic => output.italic(),
-                Effect::Strikethrough => output, // Not supported by console crate, skip it
+                Effect::Strikethrough => eyre::bail!("Not implemented: Effect::Strikethrough"),
                 Effect::Underline => output.underlined(),
                 Effect::Blink => output.blink(),
             };