Skip to content

Great inspiration! #3

@viztastic

Description

@viztastic

Thanks for this @asad-mlbd , a few thoughts:

  • Any chance you could include an example of how to connect to MongoDB in a production friendly manner.

  • Noticed you're storing password in code, pretty sure that's bad security practice across the board? Shouldn't we be using something like docker secrets or chamber to handle this?

  • Also nervous about storing any type of secret in the codebase (jwt secrets included)

  • Shouldn't there be some sort of listener for the SIGKILL, SIGINT and similar events to handle db cleanup before shut-down?

  • Would be great if there's some sort of guidance/pattern for how to store data in a produciton-friendly manner, it seems to just mount to a directly on the host computer?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions