- Minor code refactoring at Constants.kt, LocationCoordinatesUseCase.kt, PermissionHandler.kt, ResourceProvider.kt, WeatherForecastMapper.kt.

Author: asadmukhtar28

app/src/main/java/com/asad/weatherapp/data/mapper/WeatherForecastMapper.kt

@@ -6,6 +6,8 @@ import com.asad.weatherapp.domain.model.forecast.WeatherCondition
 import com.asad.weatherapp.domain.model.forecast.WeatherForecastModel
 import com.asad.weatherapp.domain.model.forecast.WeatherForecastTimeSlotModel
 import com.asad.weatherapp.domain.model.forecast.WeatherType
+import com.asad.weatherapp.utils.CLOUDS
+import com.asad.weatherapp.utils.RAIN
 import com.asad.weatherapp.utils.getDayName
 import javax.inject.Inject
 
@@ -44,8 +46,8 @@ class WeatherForecastMapper @Inject constructor() :
 
     private fun mapToWeatherType(type: String): WeatherType =
         when {
-            type.equals("Rain", ignoreCase = true) -> WeatherType.RAINY
-            type.equals("Clouds", ignoreCase = true) -> WeatherType.CLOUDY
+            type.equals(RAIN, ignoreCase = true) -> WeatherType.RAINY
+            type.equals(CLOUDS, ignoreCase = true) -> WeatherType.CLOUDY
             else -> WeatherType.SUNNY
         }
 

app/src/main/java/com/asad/weatherapp/domain/usecase/LocationCoordinatesUseCase.kt

@@ -5,7 +5,7 @@ import com.asad.weatherapp.domain.repository.LocationCoordinatesRepository
 import javax.inject.Inject
 
 class LocationCoordinatesUseCase @Inject constructor(
-    val locationCoordinatesRepository: LocationCoordinatesRepository
+    private val locationCoordinatesRepository: LocationCoordinatesRepository
 ) {
     suspend operator fun invoke(): Result<LocationCoordinates> = locationCoordinatesRepository.getCurrentLocation()
 }

app/src/main/java/com/asad/weatherapp/ui/components/PermissionHandler.kt

@@ -129,7 +129,7 @@ fun PermissionHandler(
 }
 
 @Composable
-fun PermissionDeniedUI(
+private fun PermissionDeniedUI(
     onTapAgain: () -> Unit = {},
 ) {
     Box(

app/src/main/java/com/asad/weatherapp/utils/Constants.kt

@@ -3,4 +3,6 @@ package com.asad.weatherapp.utils
 
 const val LATITUDE = "lat"
 const val LONGITUDE = "lon"
-const val APP_ID = "appid"
+const val APP_ID = "appid"
+const val RAIN = "Rain"
+const val CLOUDS = "Clouds"

app/src/main/java/com/asad/weatherapp/utils/ResourceProvider.kt

@@ -1,5 +1,7 @@
 package com.asad.weatherapp.utils
 
+import androidx.annotation.StringRes
+
 interface ResourceProvider {
-    fun getString(resId: Int, vararg args: Any): String
+    fun getString(@StringRes resId: Int, vararg args: Any): String
 }