Skip to content

Commit bb40f2e

Browse files
committed
establish new IndexGridNavigaitonPolicy
1 parent fab9745 commit bb40f2e

File tree

2 files changed

+11
-13
lines changed

2 files changed

+11
-13
lines changed

Core/include/Acts/Navigation/IndexGridNavigationPolicy.hpp

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ class IndexGridNavigationConfig {
2525
/// The binning expansion for grid neighbor lookups
2626
std::vector<std::size_t> binExpansion = {0u, 0u};
2727

28-
/// The reference expansion
28+
/// The reference expansion
2929
std::vector<double> referenceExpansion = {};
3030

3131
/// A potential lookup surface - this would be intersected first,
@@ -85,7 +85,7 @@ class IndexGridNavigationPolicy : public INavigationPolicy {
8585
AppendOnlyNavigationStream& stream,
8686
const Logger& logger) const {
8787
ACTS_VERBOSE(
88-
"IndexGridNavigationPolicy: candidates initialization for volume '"
88+
"IndexGridNavigationPolicy: candidates initialization for volume '"
8989
<< m_volume.volumeName() << "'");
9090

9191
// Nominal or intersected position
@@ -144,14 +144,13 @@ using RegularRingIndexGrid =
144144
using RegularRingIndexGridNavigationPolicy =
145145
IndexGridNavigationPolicy<RegularRingIndexGrid>;
146146

147-
148147
// Regular disc is in r and phi
149148
using RegularDiscIndexGrid =
150149
Grid<std::vector<std::size_t>,
151150
Axis<AxisType::Equidistant, AxisBoundaryType::Bound>,
152151
Axis<AxisType::Equidistant, AxisBoundaryType::Closed>>;
153152
using RegularDiscIndexGridNavigationPolicy =
154-
IndexGridNavigationPolicy<RegularDiscIndexGrid>;
153+
IndexGridNavigationPolicy<RegularDiscIndexGrid>;
155154

156155
static_assert(NavigationPolicyConcept<RegularDiscIndexGridNavigationPolicy>);
157156

@@ -161,8 +160,7 @@ using RegularPlaneIndexGrid =
161160
Axis<AxisType::Equidistant, AxisBoundaryType::Bound>,
162161
Axis<AxisType::Equidistant, AxisBoundaryType::Bound>>;
163162
using RegularPlaneIndexGridNavigationPolicy =
164-
IndexGridNavigationPolicy<RegularPlaneIndexGrid>;
165-
static_assert(
166-
NavigationPolicyConcept<RegularPlaneIndexGridNavigationPolicy>);
163+
IndexGridNavigationPolicy<RegularPlaneIndexGrid>;
164+
static_assert(NavigationPolicyConcept<RegularPlaneIndexGridNavigationPolicy>);
167165

168166
} // namespace Acts::Experimental

Tests/UnitTests/Core/Navigation/IndexGridNavigationTests.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ BOOST_AUTO_TEST_CASE(RegularPlaneIndexGridTests) {
207207

208208
BOOST_AUTO_TEST_CASE(RegularCylinderIndexGridTests) {
209209
// Most of the tests are covered by the plane grid, we can concentrate here on
210-
// the phi periodicity & the projected referecne generator
210+
// the phi periodicity & the projected reference generator
211211

212212
// Test setup:
213213
// - We create a grid in z: -20 to 20 in 20 bins in z
@@ -385,7 +385,7 @@ BOOST_AUTO_TEST_CASE(RegularDiscIndexGridTests) {
385385
*tLogger);
386386
BOOST_CHECK_EQUAL(nStream.candidates().size(), 1);
387387
BOOST_CHECK(&nStream.currentCandidate().surface() == surface0.get());
388-
// Check the neighboring bin, which shoudl not be filled by surface0 and
388+
// Check the neighboring bin, which should not be filled by surface0 and
389389
// surface1
390390
nStream.reset();
391391
navArgs.position = Vector3(7.5 * std::cos(1.1 * std::numbers::pi / 5),
@@ -421,14 +421,14 @@ BOOST_AUTO_TEST_CASE(RegularRingIndexGridTests) {
421421
BOOST_CHECK_THROW(
422422
{
423423
Experimental::IndexGridNavigationPolicy<decltype(gridPhi)>
424-
centerNavigationPolicyThrow(tContext, tVolume, *tLogger, centerConfig,
425-
indexedGridPhi);
424+
centerNavigationPolicyThrow(tContext, tVolume, *tLogger,
425+
centerConfig, indexedGridPhi);
426426
},
427427
std::runtime_error);
428428

429429
centerConfig.binExpansion = {1u};
430430

431-
Experimental::IndexGridNavigationPolicy<decltype(gridPhi)>
431+
Experimental::IndexGridNavigationPolicy<decltype(gridPhi)>
432432
centerNavigationPolicy(tContext, tVolume, *tLogger, centerConfig,
433433
indexedGridPhi);
434434
// Now initialize candidates at position (R,0,0) - should yield the surface
@@ -444,4 +444,4 @@ BOOST_AUTO_TEST_CASE(RegularRingIndexGridTests) {
444444

445445
BOOST_AUTO_TEST_SUITE_END()
446446

447-
} // namespace ActsTests
447+
} // namespace ActsTests

0 commit comments

Comments
 (0)