Group task configurations in the tasks container

Author: Abhijit Sarkar

client/build.gradle.kts

@@ -25,7 +25,10 @@ dependencies {
     errorprone(libs.errorprone)
 }
 
-val javaVersion = JavaLanguageVersion.of(rootDir.resolve(".java-version").readText(Charsets.UTF_8).trim())
+val javaVersion =
+    JavaLanguageVersion.of(
+        rootDir.resolve(".java-version").readText(Charsets.UTF_8).trim(),
+    )
 
 java {
     toolchain {
@@ -44,30 +47,35 @@ spotless {
     }
 }
 
-val ci: Boolean by lazy { listOf("CI").any { System.getenv(it) != null } }
-val spotlessTasks = arrayOf("spotlessApply", "spotlessCheck")
-val spotlessTask = spotlessTasks[true.compareTo(ci)]  // true > false
+val ci: Boolean by lazy { System.getenv("CI") != null }
 
-tasks.named(spotlessTask) {
-    enabled = false
-}
+/*
+DO NOT use existing(Task::class) for configuring tasks.
+existing() if not referenced from another task is dropped on the floor!
+Use withTask() instead.
+*/
+tasks {
+    test {
+        useJUnitPlatform()
+        testLogging {
+            showStandardStreams = true
+        }
+        // Suppress warning: Sharing is only supported for boot loader classes...
+        // https://stackoverflow.com/q/54205486/839733
+        jvmArgs("-Xshare:off")
+    }
 
-tasks.named("check") {
-    dependsOn(spotlessTasks[0])
-}
+   withType<SpotBugsTask> {
+       reports.create("html") {
+           required = !ci
+       }
+   }
 
-tasks.withType<Test> {
-    useJUnitPlatform()
-    testLogging {
-        showStandardStreams = true
+    val spotlessApply by named("spotlessApply") {
+        enabled = !ci
     }
-    // Suppress warning: Sharing is only supported for boot loader classes...
-    // https://stackoverflow.com/q/54205486/839733
-    jvmArgs("-Xshare:off")
-}
 
-tasks.withType<SpotBugsTask> {
-    reports.create("html") {
-        required = !ci
+    named("spotlessCheck") {
+        dependsOn(spotlessApply)
     }
 }

lib/build.gradle.kts

@@ -45,24 +45,6 @@ kotlin {
     }
 }
 
-tasks.withType<Jar> {
-    manifest {
-        attributes("Automatic-Module-Name" to "com.asarkar.grpc.test")
-    }
-    archiveBaseName = rootProject.name
-}
-
-tasks.withType<Test> {
-    useJUnitPlatform()
-    testLogging {
-        showStandardStreams = true
-    }
-    exclude("**/ignore/**")
-    // Suppress warning: Sharing is only supported for boot loader classes...
-    // https://stackoverflow.com/q/54205486/839733
-    jvmArgs("-Xshare:off")
-}
-
 val ci: Boolean by lazy { System.getenv("CI") != null }
 
 ktlint {
@@ -73,15 +55,6 @@ ktlint {
     additionalEditorconfig = mapOf("max_line_length" to "100")
 }
 
-tasks.withType<KtLintFormatTask> {
-    enabled = !ci
-}
-
-tasks.withType<KtLintCheckTask> {
-    val fmtTaskName = name.replace("Check", "Format")
-    dependsOn(tasks.named(fmtTaskName))
-}
-
 val gitHubUsername: String by project
 val gitHubRepo: String by lazy {
     System.getenv("GITHUB_REPOSITORY") ?: "$gitHubUsername/${rootProject.name}"
@@ -110,11 +83,6 @@ val licenseUrl: String by project
 
 version = projectVersion
 
-// https://github.com/vanniktech/gradle-maven-publish-plugin/issues/966
-tasks.withType<JavadocJar> {
-    archiveFileName = "${rootProject.name}-javadoc.jar"
-}
-
 mavenPublishing {
     configure(
         KotlinJvm(
@@ -150,3 +118,43 @@ mavenPublishing {
         }
     }
 }
+
+/*
+DO NOT use existing(Task::class) for configuring tasks.
+existing() if not referenced from another task is dropped on the floor!
+Use withTask() instead.
+*/
+tasks {
+    withType<Jar> {
+        manifest {
+            attributes("Automatic-Module-Name" to "com.asarkar.grpc.test")
+        }
+        archiveBaseName = rootProject.name
+    }
+
+    test {
+        useJUnitPlatform()
+        testLogging {
+            showStandardStreams = true
+        }
+        exclude("**/ignore/**")
+        // Suppress warning: Sharing is only supported for boot loader classes...
+        // https://stackoverflow.com/q/54205486/839733
+        jvmArgs("-Xshare:off")
+    }
+
+    // https://github.com/vanniktech/gradle-maven-publish-plugin/issues/966
+    withType<JavadocJar> {
+        archiveFileName = "${rootProject.name}-javadoc.jar"
+    }
+
+    withType<KtLintFormatTask> {
+        enabled = !ci
+    }
+
+    withType<KtLintCheckTask> {
+        val fmtTaskName = name.replace("Check", "Format")
+        val fmtTask by named(fmtTaskName)
+        dependsOn(fmtTask)
+    }
+}