feat: use host without port for RP ID (#339)

developStorm · asbiin · web-flow · commit b957ef8d8dd9 · 2021-07-03T14:01:46.000+02:00
"The origin's port is unrestricted" https://www.w3.org/TR/webauthn-2/#rp-id Co-authored-by: Alexis Saettler <alexis@saettler.org>
diff --git a/src/Services/Webauthn/PublicKeyCredentialCreationOptionsFactory.php b/src/Services/Webauthn/PublicKeyCredentialCreationOptionsFactory.php
@@ -54,7 +54,7 @@ private function createRpEntity(): PublicKeyCredentialRpEntity
     {
         return new PublicKeyCredentialRpEntity(
             $this->config->get('app.name', 'Laravel'),
-            Request::getHttpHost(),
+            Request::getHost(),
             $this->config->get('webauthn.icon')
         );
     }

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ private function createRpEntity(): PublicKeyCredentialRpEntity`
`54`	`54`	`{`
`55`	`55`	`return new PublicKeyCredentialRpEntity(`
`56`	`56`	`$this->config->get('app.name', 'Laravel'),`
`57`		`- Request::getHttpHost(),`
	`57`	`+ Request::getHost(),`
`58`	`58`	`$this->config->get('webauthn.icon')`
`59`	`59`	`);`
`60`	`60`	`}`