-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tip for combining Maven and Diagram #212
Conversation
Thanks for the update :)
wdyt? |
If you remove the required gem from the configuration, asciidoctor-maven-plugin doesn't work with asciidoctor-diagram. I know because I just tried. Adding the gem is necessary. Which setting are you talking about? You can't have static images and generated images without modifying both the |
Totally my mistake ^^'' I am so used to just copying and pasting some examples that I forget about that. The only thing you don't need is the gemPath, but you do need the require.
Yes, thinking about it, the option to generate into the sources is not something I feel comfortable promoting. BTW, since you're interested I had already worked on a prototype to integrate the maven-resources component into the plugin to be able to copy resources (#193) before the rendering, thought the 'before' part was not done yet. |
Well, if you fix the plugin, then that's even better. I think you might want to keep the text though, but change the wording. Some resources might need to be copied prior to the asciidoctor plugin running, so for this particular case it is not useful anymore with your new release, but other resources (movies?), perhaps from other folders might need to be copied prior to asciidoctor running. |
Apologies for taking so long to answer. |
Closes #207 and #196