Merge pull request #927 from robertpanzer/fix-926-extension-config-symbols

Fixes #926. Make sure that symbols stay symbols in extension config.

Author: robertpanzer

Diff for: CHANGELOG.adoc

@@ -15,6 +15,7 @@ For a detailed view of what has changed, refer to the {uri-repo}/commits/master[
 
 Bug Fixes::
 
+  * Inline macro attribute parsing changes after first document conversion (@wilkinsona) (#926)
   * Upgrade to Rouge 3.20.0, fixing error `uninitialized constant Rouge::Lexers` problem (@ahus1) (#925)
 
 == 2.3.0 (2020-05-02)

Diff for: asciidoctorj-core/src/main/java/org/asciidoctor/jruby/internal/RubyHashMapDecorator.java

@@ -144,7 +144,7 @@ private Object convertRubyValue(Object rubyValue) {
                 return NodeConverter.createASTNode(rubyObject);
             }
             if (rubyObject instanceof RubySymbol) {
-                return ((RubySymbol) rubyObject).asJavaString();
+                return ":" + rubyObject.asString();
             }
             return JavaEmbedUtils.rubyToJava((IRubyObject) rubyValue);
         } else {

Diff for: asciidoctorj-core/src/test/java/org/asciidoctor/extension/WhenTheInlineMacroProcessorRunsTwice.java

@@ -0,0 +1,36 @@
+package org.asciidoctor.extension;
+
+import org.asciidoctor.Asciidoctor;
+import org.asciidoctor.ast.ContentNode;
+import org.junit.Test;
+
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.Map;
+
+import static org.hamcrest.Matchers.containsString;
+import static org.junit.Assert.assertThat;
+
+public class WhenTheInlineMacroProcessorRunsTwice {
+
+    // See https://github.com/asciidoctor/asciidoctorj/issues/926
+    @Test
+    public void inlineMacroAttributes() {
+        Asciidoctor asciidoctor = Asciidoctor.Factory.create();
+        asciidoctor.javaExtensionRegistry().inlineMacro(new InlineMacroProcessor("example") {
+
+            @Override
+            public Object process(ContentNode parent, String target, Map<String, Object> attributes) {
+                return createPhraseNode(parent, "quoted", attributes.toString(), attributes, new HashMap<>());
+            }
+
+        });
+        assertThat(convert(asciidoctor), containsString("{format=test}"));
+        assertThat(convert(asciidoctor), containsString("{format=test}"));
+    }
+
+    private String convert(Asciidoctor asciidoctor) {
+        return asciidoctor.convert("example:alpha.bravo[format=test]", Collections.emptyMap());
+    }
+
+}