Skip to content

Soft reject additional header keys for compatibility with asciinema-edit output #106

Description

@JaneX8

Files changed using https://github.com/cirocosta/asciinema-edit contain one extra field (theme) in the header. For example:

{"version":2,"width":102,"height":51,"timestamp":1773090275,"theme":{},"env":{"SHELL":"powershell.exe"}}

Instead of in the original cast file

{"version":2,"width":102,"height":51,"timestamp":1773090275,"env":{"SHELL":"powershell.exe"}}

Therefore if trying to convert that edited file to a gif using agg it results in:

Error: not a v1, v2, v3 asciicast file

After I remove ,"theme":{} from the header, I can convert to gif using agg. I am not sure why theme is introduced by that asciinema-edit tool, but as that tool seems unmaintained, and I am not aware of alternative, I would suggest having agg soft rejecting any unused header keys instead of hard blocking conversion. As long as the minimum expected keys are present it could just do the conversion.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions