Implement tests for Language.java and LanguageSetBuilder classes

Author: ascopes

protobuf-maven-plugin/src/main/java/io/github/ascopes/protobufmavenplugin/generation/Language.java

@@ -16,6 +16,7 @@
 package io.github.ascopes.protobufmavenplugin.generation;
 
 import java.util.EnumSet;
+import java.util.Set;
 
 /**
  * Supported generated source languages.
@@ -27,7 +28,7 @@ public enum Language {
   JAVA("java"),
   KOTLIN("kotlin"),
   PYTHON("python"),
-  PYI("pyi"),
+  PYTHON_STUBS("pyi"),
   RUBY("ruby");
 
   private final String flagName;
@@ -45,7 +46,7 @@ public String getFlagName() {
     return flagName;
   }
 
-  public static LanguageSetBuilder languageSet() {
+  public static LanguageSetBuilder setBuilder() {
     return new LanguageSetBuilder();
   }
 
@@ -64,15 +65,13 @@ private LanguageSetBuilder() {
     }
 
     public LanguageSetBuilder addIf(boolean condition, Language language) {
-      return condition ? add(language) : this;
-    }
-
-    public LanguageSetBuilder add(Language language) {
-      values.add(language);
+      if (condition) {
+        values.add(language);
+      }
       return this;
     }
 
-    public EnumSet<Language> build() {
+    public Set<Language> build() {
       return values;
     }
   }

protobuf-maven-plugin/src/main/java/io/github/ascopes/protobufmavenplugin/mojo/AbstractGenerateMojo.java

@@ -1066,11 +1066,11 @@ public void execute() throws MojoExecutionException, MojoFailureException {
       return;
     }
 
-    var enabledLanguages = Language.languageSet()
+    var enabledLanguages = Language.setBuilder()
         .addIf(javaEnabled, Language.JAVA)
         .addIf(kotlinEnabled, Language.KOTLIN)
         .addIf(pythonEnabled, Language.PYTHON)
-        .addIf(pythonStubsEnabled, Language.PYI)
+        .addIf(pythonStubsEnabled, Language.PYTHON_STUBS)
         .addIf(rubyEnabled, Language.RUBY)
         .build();
 

protobuf-maven-plugin/src/test/java/io/github/ascopes/protobufmavenplugin/generation/LanguageTest.java

@@ -0,0 +1,45 @@
+package io.github.ascopes.protobufmavenplugin.generation;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import org.junit.jupiter.api.DisplayName;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.CsvSource;
+
+@DisplayName("Language tests")
+class LanguageTest {
+
+  @CsvSource({
+      "        JAVA,   --java_out=",
+      "      KOTLIN, --kotlin_out=",
+      "      PYTHON, --python_out=",
+      "PYTHON_STUBS,    --pyi_out=",
+      "        RUBY,   --ruby_out=",
+  })
+  @DisplayName("Language enum members have the expected output flag format")
+  @ParameterizedTest(name = "for {0}")
+  void languageEnumMembersHaveExpectedOutputFlagFormat(Language language, String expectedFlag) {
+    // When
+    var actualFlag = "--%s_out=".formatted(language.getFlagName());
+
+    // Then
+    assertThat(actualFlag).isEqualTo(expectedFlag);
+  }
+
+  @DisplayName("LanguageSetBuilder creates an enum of the enabled languages")
+  @Test
+  void languageSetBuilderCreatesEnumOfEnabledLanguages() {
+    // When
+    var enumSet = Language.setBuilder()
+        .addIf(true, Language.PYTHON_STUBS)
+        .addIf(true, Language.PYTHON)
+        .addIf(false, Language.RUBY)
+        .addIf(true, Language.JAVA)
+        .build();
+
+    // Then
+    assertThat(enumSet)
+        .containsExactlyInAnyOrder(Language.PYTHON_STUBS, Language.PYTHON, Language.JAVA);
+  }
+}

protobuf-maven-plugin/src/test/java/io/github/ascopes/protobufmavenplugin/mojo/AbstractGenerateMojoTestTemplate.java

@@ -76,7 +76,6 @@
 import org.mockito.ArgumentCaptor;
 import org.mockito.quality.Strictness;
 
-@SuppressWarnings("removal")
 abstract class AbstractGenerateMojoTestTemplate<A extends AbstractGenerateMojo> {
 
   @TempDir
@@ -1172,7 +1171,7 @@ static Stream<Arguments> languageEnablingCases() {
         arguments("Java", consumer(a -> a.javaEnabled = true), EnumSet.of(Language.JAVA)),
         arguments("Kotlin", consumer(a -> a.kotlinEnabled = true), EnumSet.of(Language.KOTLIN)),
         arguments("Python", consumer(a -> a.pythonEnabled = true), EnumSet.of(Language.PYTHON)),
-        arguments("PYI", consumer(a -> a.pythonStubsEnabled = true), EnumSet.of(Language.PYI)),
+        arguments("PYI", consumer(a -> a.pythonStubsEnabled = true), EnumSet.of(Language.PYTHON_STUBS)),
         arguments("Ruby", consumer(a -> a.rubyEnabled = true), EnumSet.of(Language.RUBY)),
         // Combined cases
         arguments(
@@ -1189,7 +1188,7 @@ static Stream<Arguments> languageEnablingCases() {
               a.pythonEnabled = true;
               a.pythonStubsEnabled = true;
             }),
-            EnumSet.of(Language.PYTHON, Language.PYI)
+            EnumSet.of(Language.PYTHON, Language.PYTHON_STUBS)
         ),
         arguments(
             "everything",