Merge pull request #790 from ascopes/task/enable-parallel-it-execution

Re-enable parallel test execution for integration tests

Author: ascopes

.github/workflows/build.yml

@@ -159,7 +159,7 @@ jobs:
 
       - name: Build and test
         shell: bash
-        run: ./mvnw -B -Dcheckstyle.skip -Dlicense.skip clean verify
+        run: time ./mvnw -B -Dcheckstyle.skip -Dlicense.skip clean verify
 
       - name: Publish code coverage
         uses: codecov/codecov-action@v4

protobuf-maven-plugin/pom.xml

@@ -188,13 +188,15 @@
               <failIfNoProjects>true</failIfNoProjects>
               <!-- Warning: placing this inside the cloneProjectsTo path triggers a resolution bug in the plugin -->
               <localRepositoryPath>${project.basedir}/target/it-repo</localRepositoryPath>
-              <!-- Set to 1 for now to avoid flaky builds on GitHub. -->
-              <parallelThreads>1</parallelThreads>
+              <parallelThreads>2C</parallelThreads>
               <postBuildHookScript>test</postBuildHookScript>
               <properties>
-                <!-- Acquire locks where-ever we run Maven to avoid parallel tests trampling across eachother. -->
+                <!-- Acquire locks whereever we run Maven to avoid parallel tests trampling across eachother. -->
                 <aether.syncContext.named.factory>file-lock</aether.syncContext.named.factory>
                 <aether.syncContext.named.nameMapper>file-gav</aether.syncContext.named.nameMapper>
+                <!-- Avoid https://bugs.openjdk.org/browse/JDK-8252883 on Windows -->
+                <aether.named.file-lock.attempts>10</aether.named.file-lock.attempts>
+                <aether.named.file-lock.sleepMillis>500</aether.named.file-lock.sleepMillis>
               </properties>
               <setupIncludes>
                 <setupInclude>setup</setupInclude>

protobuf-maven-plugin/src/it/gh-782-sanctioned-executable-paths/src/test/java/org/example/helloworld/ReactorGreetingServiceImplTest.java

@@ -27,17 +27,18 @@ void greetingServiceWorksAsExpected() throws Throwable {
     // Given
     var service = new ReactorGreetingServiceImpl();
     var server = ServerBuilder
-        .forPort(8084)
+        .forPort(0)
         .addService(service)
         .build();
-    var channel = ManagedChannelBuilder.forAddress("localhost", 8084)
-        .usePlaintext()
-        .build();
-    var stub = ReactorGreetingServiceGrpc.newReactorStub(channel);
 
     try {
       server.start();
 
+      var channel = ManagedChannelBuilder.forAddress("localhost", server.getPort())
+          .usePlaintext()
+          .build();
+      var stub = ReactorGreetingServiceGrpc.newReactorStub(channel);
+
       // When
       var request = GreetingRequest
           .newBuilder()

protobuf-maven-plugin/src/it/per-plugin-output-paths/src/test/java/org/example/helloworld/ReactorGreetingServiceImplTest.java

@@ -27,17 +27,18 @@ void greetingServiceWorksAsExpected() throws Throwable {
     // Given
     var service = new ReactorGreetingServiceImpl();
     var server = ServerBuilder
-        .forPort(8083)
+        .forPort(0)
         .addService(service)
         .build();
-    var channel = ManagedChannelBuilder.forAddress("localhost", 8083)
-        .usePlaintext()
-        .build();
-    var stub = ReactorGreetingServiceGrpc.newReactorStub(channel);
 
     try {
       server.start();
 
+      var channel = ManagedChannelBuilder.forAddress("localhost", server.getPort())
+          .usePlaintext()
+          .build();
+      var stub = ReactorGreetingServiceGrpc.newReactorStub(channel);
+
       // When
       var request = GreetingRequest
           .newBuilder()

protobuf-maven-plugin/src/it/reactor-grpc-binary-plugin/src/test/java/org/example/helloworld/ReactorGreetingServiceImplTest.java

@@ -27,17 +27,18 @@ void greetingServiceWorksAsExpected() throws Throwable {
     // Given
     var service = new ReactorGreetingServiceImpl();
     var server = ServerBuilder
-        .forPort(8083)
+        .forPort(0)
         .addService(service)
         .build();
-    var channel = ManagedChannelBuilder.forAddress("localhost", 8083)
-        .usePlaintext()
-        .build();
-    var stub = ReactorGreetingServiceGrpc.newReactorStub(channel);
 
     try {
       server.start();
 
+      var channel = ManagedChannelBuilder.forAddress("localhost", server.getPort())
+          .usePlaintext()
+          .build();
+      var stub = ReactorGreetingServiceGrpc.newReactorStub(channel);
+
       // When
       var request = GreetingRequest
           .newBuilder()

protobuf-maven-plugin/src/it/reactor-grpc-jvm-plugin/src/test/java/org/example/helloworld/ReactorGreetingServiceImplTest.java

@@ -27,17 +27,18 @@ void greetingServiceWorksAsExpected() throws Throwable {
     // Given
     var service = new ReactorGreetingServiceImpl();
     var server = ServerBuilder
-        .forPort(8084)
+        .forPort(0)
         .addService(service)
         .build();
-    var channel = ManagedChannelBuilder.forAddress("localhost", 8084)
-        .usePlaintext()
-        .build();
-    var stub = ReactorGreetingServiceGrpc.newReactorStub(channel);
 
     try {
       server.start();
 
+      var channel = ManagedChannelBuilder.forAddress("localhost", server.getPort())
+          .usePlaintext()
+          .build();
+      var stub = ReactorGreetingServiceGrpc.newReactorStub(channel);
+
       // When
       var request = GreetingRequest
           .newBuilder()