Refactor CI workflow and unify setup

Add shared env lists for Ubuntu and macOS packages, switch the matrix to
include entries with an is_legacy flag, and unify system package
installation into a single step. Consolidate PHP configuration and
installation (exporting vars to GITHUB_ENV, legacy compiler handling and
diagnostics), add job timeout, and simplify lint/format steps with minor
improvements (curl -sL).

Author: Rusydy

.github/workflows/workflow.yml

@@ -17,28 +17,33 @@ on:
   schedule:
     - cron: 0 0 * * 5
 
+env:
+  # Common dependencies for all builds
+  UBUNTU_DEPS: "autoconf bison build-essential curl gettext git libgd-dev libcurl4-openssl-dev libedit-dev libicu-dev libjpeg-dev libmysqlclient-dev libonig-dev libpng-dev libpq-dev libreadline-dev libsqlite3-dev libssl-dev libxml2-dev libzip-dev libtidy-dev openssl pkg-config re2c zlib1g-dev ca-certificates wget libtool automake gcc-9 g++-9 libxslt1.1 libxslt1-dev autotools-dev m4 libtool-bin"
+  MACOS_DEPS: "autoconf automake bison freetype gd gettext icu4c krb5 libedit libiconv libjpeg libpng libxml2 libzip openssl@1.1 openssl@3 pkg-config re2c zlib"
+
 jobs:
   plugin_test:
     strategy:
       fail-fast: false
       matrix:
-        os:
+        include:
           - os: ubuntu-latest
             version: 8.0.0
+            is_legacy: true
           # will uncomment later; currently focus on php 8.0.0
           # - os: ubuntu-latest
           #   version: 7.4.14
+          #   is_legacy: true
           # - os: ubuntu-latest
           #   version: latest
-          # will uncomment later; currently focus on linux
+          #   is_legacy: false
           # - os: macos-latest
           #   version: 8.0.0
-          # - os: macos-latest
-          #   version: 7.4.14
-          # - os: macos-latest
-          #   version: latest
+          #   is_legacy: true
 
-    runs-on: ${{ matrix.os.os }}
+    runs-on: ${{ matrix.os }}
+    timeout-minutes: 45
 
     steps:
       - name: Checkout code
@@ -49,69 +54,32 @@ jobs:
           git submodule update --init --recursive
           chmod +x bin/* lib/*
 
-      - name: Install system packages on Ubuntu
-        if: ${{ runner.os == 'Linux' }}
+      - name: Install system packages
         run: |
-          if command -v sudo >/dev/null 2>&1; then
+          set -e
+          if [ "${{ runner.os }}" = "Linux" ]; then
             sudo apt-get update
-            sudo apt-get install -y autoconf bison build-essential curl gettext git libgd-dev libcurl4-openssl-dev libedit-dev libicu-dev libjpeg-dev libmysqlclient-dev libonig-dev libpng-dev libpq-dev libreadline-dev libsqlite3-dev libssl-dev libxml2-dev libzip-dev libtidy-dev openssl pkg-config re2c zlib1g-dev ca-certificates wget libtool automake gcc-9 g++-9 libxslt1.1 libxslt1-dev
-          else
-            apt-get update
-            apt-get install -y autoconf bison build-essential curl gettext git libgd-dev libcurl4-openssl-dev libedit-dev libicu-dev libjpeg-dev libmysqlclient-dev libonig-dev libpng-dev libpq-dev libreadline-dev libsqlite3-dev libssl-dev libxml2-dev libzip-dev libtidy-dev openssl pkg-config re2c zlib1g-dev ca-certificates wget libtool automake gcc-9 g++-9 libxslt1.1 libxslt1-dev
+            sudo apt-get install -y ${{ env.UBUNTU_DEPS }}
+          elif [ "${{ runner.os }}" = "macOS" ]; then
+            brew install ${{ env.MACOS_DEPS }}
           fi
 
-      - name: Install system packages on macOS
-        if: ${{ runner.os == 'macOS' }}
-        run: brew install autoconf automake bison freetype gd gettext icu4c krb5 libedit libiconv libjpeg libpng libxml2 libzip openssl@1.1 openssl@3 pkg-config re2c zlib
-
       - name: Setup asdf
         uses: asdf-vm/actions/setup@v4
 
-      - name: Fix autotools for PHP 8.0.0
-        if: ${{ matrix.os.version == '8.0.0' || matrix.os.version == '7.4.14' }}
-        run: |
-          # Install compatible autotools for old PHP versions
-          if command -v sudo >/dev/null 2>&1; then
-            sudo apt-get install -y autotools-dev m4 libtool-bin
-          else
-            apt-get install -y autotools-dev m4 libtool-bin
-          fi
-          echo "Autotools installed for PHP ${{ matrix.os.version }}"
-
-      - name: Test plugin
-        timeout-minutes: 45
+      - name: Configure environment for PHP ${{ matrix.version }}
         run: |
           # Add plugin from current checkout
           asdf plugin add php $GITHUB_WORKSPACE
 
-          # Set version-specific configuration
-          if [ "${{ matrix.os.version }}" = "8.0.0" ]; then
-            echo "=== Configuring for PHP 8.0.0 ==="
-            # Verify gcc-9 is available, fallback to gcc if not
-            if command -v gcc-9 >/dev/null 2>&1; then
-              COMPILER="gcc-9"
-              CXXCOMPILER="g++-9"
-            else
-              COMPILER="gcc"
-              CXXCOMPILER="g++"
-            fi
-
-            # Export all variables for php-build
-            export ASDF_PHP_OPENSSL_AUTO=yes
-            export PHP_BUILD_XDEBUG_ENABLE=off
-            export CC="$COMPILER"
-            export CXX="$CXXCOMPILER"
-
-            # Set for autoconf/configure scripts
-            export ac_cv_prog_CC="$COMPILER"
-            export ac_cv_prog_CXX="$CXXCOMPILER"
+          # Set common environment
+          export PHP_BUILD_XDEBUG_ENABLE=off
+          echo "PHP_BUILD_XDEBUG_ENABLE=off" >> $GITHUB_ENV
 
-            # Set CONFIG_SHELL for consistent shell behavior
-            export CONFIG_SHELL="/bin/bash"
+          if [ "${{ matrix.is_legacy }}" = "true" ]; then
+            echo "=== Configuring for legacy PHP ${{ matrix.version }} ==="
 
-          elif [ "${{ matrix.os.version }}" = "7.4.14" ]; then
-            echo "=== Configuring for PHP 7.4.14 ==="
-            # Verify gcc-9 is available, fallback to gcc if not
+            # Use gcc-9 for legacy versions, fallback to gcc
             if command -v gcc-9 >/dev/null 2>&1; then
               COMPILER="gcc-9"
               CXXCOMPILER="g++-9"
@@ -120,114 +88,74 @@ jobs:
               CXXCOMPILER="g++"
             fi
 
-            export ASDF_PHP_OPENSSL_AUTO=yes
-            export PHP_BUILD_XDEBUG_ENABLE=off
-            export CC="$COMPILER"
-            export CXX="$CXXCOMPILER"
-
-            # Set for autoconf/configure scripts
-            export ac_cv_prog_CC="$COMPILER"
-            export ac_cv_prog_CXX="$CXXCOMPILER"
-
-            # Set CONFIG_SHELL for consistent shell behavior
-            export CONFIG_SHELL="/bin/bash"
-
-          else
-            echo "=== Configuring for PHP latest ==="
-            export ASDF_PHP_OPENSSL_AUTO=no
-            export PHP_BUILD_XDEBUG_ENABLE=off
-            export CC="gcc"
-            export CXX="g++"
-          fi
-
-          # Debug compiler setup for problematic versions
-          if [ "${{ matrix.os.version }}" = "8.0.0" ] || [ "${{ matrix.os.version }}" = "7.4.14" ]; then
-            echo "=== Compiler Debug Info ==="
-            echo "CC=$CC"
-            echo "CXX=$CXX"
-            echo "ac_cv_prog_CC=$ac_cv_prog_CC"
-            echo "CFLAGS=$CFLAGS"
+            # Set legacy-specific environment
+            echo "ASDF_PHP_OPENSSL_AUTO=yes" >> $GITHUB_ENV
+            echo "CC=$COMPILER" >> $GITHUB_ENV
+            echo "CXX=$CXXCOMPILER" >> $GITHUB_ENV
+            echo "ac_cv_prog_CC=$COMPILER" >> $GITHUB_ENV
+            echo "ac_cv_prog_CXX=$CXXCOMPILER" >> $GITHUB_ENV
+            echo "CONFIG_SHELL=/bin/bash" >> $GITHUB_ENV
 
-            echo "Compiler version:"
-            $CC --version || echo "Compiler not found"
-
-            echo "Testing basic compilation:"
+            # Debug output
+            echo "Compiler: $COMPILER ($($COMPILER --version | head -1))"
             echo 'int main() { return 0; }' > /tmp/test.c
-            $CC $CFLAGS -o /tmp/test /tmp/test.c && echo "✓ Basic compilation works" || echo "✗ Basic compilation FAILED"
+            $COMPILER -o /tmp/test /tmp/test.c && echo "✓ Compiler works" || echo "✗ Compiler failed"
             rm -f /tmp/test /tmp/test.c
-
-            echo "Environment variables that will be passed to php-build:"
-            env | grep -E "^(CC|CXX|CFLAGS|CXXFLAGS|LDFLAGS|ac_cv_)" | sort
+          else
+            echo "=== Configuring for modern PHP ${{ matrix.version }} ==="
+            echo "ASDF_PHP_OPENSSL_AUTO=no" >> $GITHUB_ENV
+            echo "CC=gcc" >> $GITHUB_ENV
+            echo "CXX=g++" >> $GITHUB_ENV
           fi
 
-          # Install PHP version with enhanced error handling for old versions
-          echo "Installing PHP ${{ matrix.os.version }}..."
-
-          if [ "${{ matrix.os.version }}" = "8.0.0" ] || [ "${{ matrix.os.version }}" = "7.4.14" ]; then
-            asdf install php ${{ matrix.os.version }} || {
-              echo "Build failed, examining config.log and environment..."
-              echo "=== Final Environment Check ==="
-              echo "CC: $CC ($(which $CC 2>/dev/null || echo 'NOT FOUND'))"
-              echo "ac_cv_prog_CC: $ac_cv_prog_CC"
-              echo "CONFIG_SHELL: $CONFIG_SHELL"
-
-              echo "=== Config Log ==="
-              find /tmp -name "config.log" -path "*/php-build/source/${{ matrix.os.version }}/*" -exec tail -100 {} \;
-
-              echo "=== Configure Script Status ==="
-              find /tmp -path "*/php-build/source/${{ matrix.os.version }}/configure" -ls
-
-              echo "=== Full PHP build log ==="
-              find /tmp -name "php-build.${{ matrix.os.version }}.*.log" -exec tail -200 {} \;
-              exit 1
-            }
-          else
-            asdf install php ${{ matrix.os.version }}
+      - name: Install PHP ${{ matrix.version }}
+        run: |
+          echo "Installing PHP ${{ matrix.version }}..."
+
+          if ! asdf install php ${{ matrix.version }}; then
+            if [ "${{ matrix.is_legacy }}" = "true" ]; then
+              echo "=== Build failed - gathering diagnostics ==="
+              echo "Environment: CC=$CC, ac_cv_prog_CC=$ac_cv_prog_CC"
+              find /tmp -name "config.log" -path "*/php-build/source/${{ matrix.version }}/*" -exec tail -50 {} \;
+              find /tmp -name "php-build.${{ matrix.version }}.*.log" -exec tail -100 {} \;
+            fi
+            exit 1
           fi
 
-          # Set global and test
-          asdf set php ${{ matrix.os.version }}
-          echo "Testing PHP installation..."
+      - name: Test PHP installation
+        run: |
+          asdf set php ${{ matrix.version }}
           php --version
+          echo "Installation path: $(asdf where php)"
 
-          echo "PHP installation path:"
-          asdf where php
-
-      - name: Test Composer (if available)
-        if: success()
-        run: |
-          composer --version || echo "Composer not available"
-        continue-on-error: true
+          # Test Composer if available
+          if command -v composer >/dev/null 2>&1; then
+            echo "Composer: $(composer --version)"
+          else
+            echo "Composer not available"
+          fi
 
   lint:
     runs-on: ubuntu-latest
-
     steps:
-      - name: Checkout code
-        uses: actions/checkout@v4
-
-      - name: Install ShellCheck and make
+      - uses: actions/checkout@v4
+      - name: Install dependencies
         run: |
           sudo apt-get update
           sudo apt-get install -y shellcheck make
-
-      - name: Run ShellCheck
+      - name: Run lint
         run: make lint
 
   format:
     runs-on: ubuntu-latest
-
     steps:
-      - name: Checkout code
-        uses: actions/checkout@v4
-
-      - name: Install shfmt and make
+      - uses: actions/checkout@v4
+      - name: Install dependencies
         run: |
           sudo apt-get update
           sudo apt-get install -y make
-          curl -L "https://github.com/mvdan/sh/releases/download/v3.8.0/shfmt_v3.8.0_linux_amd64" -o shfmt
+          curl -sL "https://github.com/mvdan/sh/releases/download/v3.8.0/shfmt_v3.8.0_linux_amd64" -o shfmt
           chmod +x shfmt
           sudo mv shfmt /usr/local/bin/
-
-      - name: Run shfmt
+      - name: Check format
         run: make fmt-check