Reverted default write_checksums behavior to True

Author: sydduckworth

asdf/_block/io.py

@@ -276,7 +276,7 @@ def callback():
 
 
 def generate_write_header(
-    data, stream=False, compression_kwargs=None, padding=False, fs_block_size=1, write_checksum=False, **header_kwargs
+    data, stream=False, compression_kwargs=None, padding=False, fs_block_size=1, write_checksum=True, **header_kwargs
 ):
     """
     Generate a dict representation of a ASDF block header that can be
@@ -309,7 +309,7 @@ def generate_write_header(
         The filesystem block size. See the `asdf.util.calculate_padding`
         ``block_size`` argument for more details.
 
-    write_checksum: bool, optional, default False
+    write_checksum: bool, optional
         Compute and write the checksum of the block data.
         If disabled then the checksum field is set to 0.
 
@@ -377,7 +377,7 @@ def generate_write_header(
 
 
 def write_block(
-    fd, data, offset=None, stream=False, compression_kwargs=None, padding=False, write_checksum=False, **header_kwargs
+    fd, data, offset=None, stream=False, compression_kwargs=None, padding=False, write_checksum=True, **header_kwargs
 ):
     """
     Write an ASDF block.
@@ -400,7 +400,7 @@ def write_block(
     padding : bool, optional, default False
         Optionally pad the block data. See `generate_write_header`.
 
-    write_checksum: bool, optional, default False
+    write_checksum: bool, optional
         Compute and write the checksum of the block data.
         If disabled then the checksum field is set to 0.
 

asdf/_block/manager.py

@@ -605,10 +605,8 @@ def update(self, new_tree_size, pad_blocks, include_block_index, write_checksums
             If a streamed_block is provided (or the file is not
             seekable) no block index will be written.
 
-        write_checksums: bool or None, optional
+        write_checksums: bool, optional
             Compute and write block checksums to the file.
-            If `None` then checksums will be written if the existing blocks
-            in the file contain checksums. Otherwise defaults to `False`.
 
         Raises
         ------

asdf/_block/writer.py

@@ -29,7 +29,7 @@ def data_bytes(self):
         return np.ndarray(0, np.uint8)
 
 
-def write_blocks(fd, blocks, padding=False, streamed_block=None, write_index=True, write_checksums=False):
+def write_blocks(fd, blocks, padding=False, streamed_block=None, write_index=True, write_checksums=True):
     """
     Write a list of WriteBlocks to a file
 

asdf/_tests/_block/test_io.py

@@ -140,8 +140,7 @@ def test_write_block(tmp_path):
         + b"\0\0\0\0\0\0\0\0"  # allocated size
         + b"\0\0\0\0\0\0\0\0"  # used size
         + b"\0\0\0\0\0\0\0\0"  # data size
-        + b"\0" * 16  # checksum is disabled
-        # + b"\xd4\x1d\x8c\xd9\x8f\x00\xb2\x04\xe9\x80\t\x98\xec\xf8B~"  # checksum
+        + b"\xd4\x1d\x8c\xd9\x8f\x00\xb2\x04\xe9\x80\t\x98\xec\xf8B~"  # checksum
     )
 
     # first write out a file with a block

asdf/_tests/_block/test_manager.py

@@ -76,7 +76,7 @@ def test_update_outside_context(tmp_path):
     with asdf.open(fn) as af:
         m = af._blocks
         with pytest.raises(OSError, match=r"update called outside of valid write_context"):
-            m.update(0, pad_blocks=False, include_block_index=False, write_checksums=None)
+            m.update(0, pad_blocks=False, include_block_index=False, write_checksums=False)
 
 
 def test_input_compression(tmp_path):

asdf/_tests/_block/test_reader.py

@@ -57,7 +57,8 @@ def check(blocks):
 @pytest.mark.parametrize("validate_checksums", [True, False])
 @pytest.mark.parametrize("padding", [0, 3, 4, 5])
 @pytest.mark.parametrize("streamed", [True, False])
-def test_read(tmp_path, lazy_load, memmap, with_index, validate_checksums, padding, streamed):
+@pytest.mark.parametrize("write_checksums", [True, False])
+def test_read(tmp_path, lazy_load, memmap, with_index, validate_checksums, padding, streamed, write_checksums):
     fn = tmp_path / "test.bin"
     n = 5
     size = 10
@@ -68,7 +69,7 @@ def test_read(tmp_path, lazy_load, memmap, with_index, validate_checksums, paddi
         padding=padding,
         with_index=with_index,
         streamed=streamed,
-        write_checksums=validate_checksums,
+        write_checksums=write_checksums,
     ) as (fd, check):
         r = read_blocks(fd, memmap=memmap, lazy_load=lazy_load, validate_checksums=validate_checksums)
         if lazy_load and with_index and not streamed: