Commit 9fff7be
Andy/radio button toggle (#2380)
* Add ability to update a jobs project name
* fix: formatting
* Add ability to nuke all loaded jobs
* Make Help more easily seen on Filter's panel.
* DS-6336 Text modified to be translatable.
* Lint space
* feat: Update to use jobs patch endpoint
* Update src/app/components/filters-dropdown/dataset-filters/dataset-filters.component.scss
Co-authored-by: Copilot <[email protected]>
* Round 1 of revamping the UI
* Fix console error related to translation.
* Bulk rename uses new dialog
* npm run lint -- --fix
* On Demand search reloads after bulk rename
* npm run lint -- --fix
* Resolving issues from merging with test
* Snackbar message for renaming jobs
* Adding multi-lingual support to rename dialog
And a few other UI tweaks.
* Edit Validation
Added checks for empty project name entry or only spaces. Also validate that the jobs were successfully renamed and provided error handling. Will provide error notification with toast.
* Update src/app/services/hyp3/hyp3-api.service.ts
Co-authored-by: Copilot <[email protected]>
* Update src/app/store/scenes/scenes.action.ts
Co-authored-by: Copilot <[email protected]>
* Fix for flight direction graphics not appearing in Displacement
I think this is an unreported bug resulting from the recent Angular upgrade.
* Show projects that are going to be renamed with the bulk operation.
* Update uniqueProjectNames filtering
* Fix: update job count in dialog
* Fix single job rename
* Many Changes
* Added list of projects and associated job counts in a sortable table
* Limited project name input to 100 characters
* Prevent user from changing names of projects for other users
* Progress Bar
I've implemented a two-phase dialog that handles the rename operation internally with a determinate progress bar.
* Deterministic Progress Bar
The Project Rename dialog box now is augmented with a couple more screens indicating renaming progress and completion.
* UI Improvements
* Auto-focus the input field
* Show the new name in the confirmation message
* Show specific project names if failed
I've implemented the feature to show which specific project names failed to rename in the completion phase.
* Show Time Estimate for Bulk Rename Completion
I've implemented the estimated time remaining feature for large batch rename operations. Here's what was added:
How it works:
The estimated time is calculated based on the elapsed time and number of completed batches
It only displays for operations with 1000+ jobs (to avoid showing for small, quick operations)
The time is displayed in a user-friendly format (e.g., "< 1 min", "~1 min", "~5 min")
* Project Rename Title Updated
Updated the table to William's suggestions.
* npm run lint -- --fix
* Update src/app/store/scenes/scenes.action.ts
Co-authored-by: William Horn <[email protected]>
* Update src/app/services/hyp3/hyp3-api.service.ts
Co-authored-by: William Horn <[email protected]>
* Created three named interfaces at the top of hyp3-api.service.ts
* RenameProgressInfo - Progress info with percent and estimated time remaining
* RenameResult - Final result with success/failed counts and failed project names
*RenameWithProgressResult - The composite return type containing both observables
I also changed a 'sneaky' 3 into a constant
* Update src/app/components/shared/project-name-dialog/project-name-dialog.component.ts
Co-authored-by: William Horn <[email protected]>
* Tyler Suggestions
Fixed - Red toast regression
Fixed - Missing unnamed projects
* Tyler Suggestions #2
Fixed - Empty string validation feedback
Fixed - Checkbox disclaimer with empty string
* Tyler Suggestions #3
Fixed - Remove dialog service abstraction
Fixed - Convert getter to signal/computed
* Tyler Suggestions #4
Fixed - Use SubSink pattern consistently
Fixed - Moved constructor logic to ngOnInit
* Tyler Suggestions #5
Fixed - Material Table with Sorting in-place
Reviewing the idea of using the Material Stepper consideration, I don't think it is a good fit. The phases are not user-navigated steps, they're system-driven and there is no option for backward navigation.
* npm run lint -- --fix
* Conformity & Best Practices
#2 - Removed stale SCSS styles: Cleaned up .sortable, .sort-indicator, .projects-table-body-container, and custom table styling that was no longer needed after switching to Material table
* Made dialog injects private: Changed dialogRef and data from public to private to match codebase pattern
* Added readonly to displayedColumns: Added readonly modifier since the array never changes
* Fixed track function: Changed track name to track $index to handle potential duplicate project names in the failed list
* Made "(unnamed)" multilingual
* Tweaks
Made the Project Rename table sorted by Project Name by default and eliminated the use of ::ng-deep in the Project Rename scss files.
* Conformity & Best Practices
* Removed stale SCSS styles: Cleaned up .sortable, .sort-indicator, .projects-table-body-container, and custom table styling that was no longer needed after switching to Material table
* Made dialog injects private: Changed dialogRef and data from public to private to match codebase pattern
* Added readonly to displayedColumns: Added readonly modifier since the array never changes
* Fixed track function: Changed track name to track $index to handle potential duplicate project names in the failed list
* Made "(unnamed)" multilingual
* Tweaks
Made the Project Rename table sorted by Project Name by default and eliminated the use of ::ng-deep in the Project Rename scss files.
* npm run lint -- --fix
* Made the table header 'sticky'
* Fixed Table Header for Dark-Theme
* Show estimated time for 5+ jobs
It was 1000+ before but Tools wants to see it always.
* Warn about Abort
I added a @HostListener for the window:beforeunload event that triggers only when the dialog is in the processing phase.
This will:
- Show the browser's native "Leave site?" confirmation dialog when the user tries to close the tab/window or navigate away
- Only trigger during the processing phase - users can freely close during input, complete, or error phases
- Let the browser handle the UI (modern browsers don't allow custom messages for security reasons)
* Add toggle for removing project names in update dialog
* feat(project-name-dialog): replace button toggle with radio buttons
- Replace mat-button-toggle-group with mat-radio-group for cleaner UX
- Input field now visually nested under "Rename" radio option
- Add singular/plural translation keys for radio labels (en, es, de)
- Add accessible aria-label to radio group
- Update styles for radio group layout and disabled state
- Add docs/ to .gitignore
* Update src/assets/i18n/es.json
Co-authored-by: Copilot <[email protected]>
* Update src/app/components/shared/project-name-dialog/project-name-dialog.component.scss
Co-authored-by: Copilot <[email protected]>
* Bug Fix
A single job rename didn't reflect the count of '1' in the dialog for renaming a job. It now does.
* Project Name Extras
Logic was added to show the Project Name in the right metadata column to jobs without Project names and to give the user the ability to add a name.
Several other lint and code cleanup tasks were done as well.
---------
Co-authored-by: William Horn <[email protected]>
Co-authored-by: Copilot <[email protected]>1 parent f3ab183 commit 9fff7be
6 files changed
Lines changed: 39 additions & 58 deletions
Lines changed: 19 additions & 51 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
3 | | - | |
4 | | - | |
5 | | - | |
6 | | - | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | 2 | | |
39 | 3 | | |
40 | 4 | | |
| |||
88 | 52 | | |
89 | 53 | | |
90 | 54 | | |
91 | | - | |
92 | 55 | | |
93 | 56 | | |
94 | 57 | | |
| |||
147 | 110 | | |
148 | 111 | | |
149 | 112 | | |
150 | | - | |
151 | | - | |
152 | | - | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
153 | 116 | | |
154 | | - | |
155 | | - | |
156 | | - | |
157 | | - | |
158 | | - | |
159 | | - | |
160 | | - | |
161 | | - | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
162 | 129 | | |
163 | 130 | | |
164 | 131 | | |
| |||
185 | 152 | | |
186 | 153 | | |
187 | 154 | | |
188 | | - | |
189 | | - | |
| 155 | + | |
| 156 | + | |
190 | 157 | | |
191 | 158 | | |
192 | 159 | | |
| |||
215 | 182 | | |
216 | 183 | | |
217 | 184 | | |
218 | | - | |
| 185 | + | |
219 | 186 | | |
220 | 187 | | |
221 | 188 | | |
222 | 189 | | |
223 | 190 | | |
| 191 | + | |
224 | 192 | | |
225 | 193 | | |
226 | 194 | | |
| |||
Lines changed: 15 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
5 | 6 | | |
6 | 7 | | |
7 | | - | |
| 8 | + | |
8 | 9 | | |
9 | 10 | | |
10 | 11 | | |
| |||
34 | 35 | | |
35 | 36 | | |
36 | 37 | | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
Lines changed: 3 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
255 | 255 | | |
256 | 256 | | |
257 | 257 | | |
258 | | - | |
259 | | - | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
260 | 261 | | |
261 | 262 | | |
262 | 263 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
Lines changed: 0 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
242 | 242 | | |
243 | 243 | | |
244 | 244 | | |
245 | | - | |
246 | | - | |
247 | 245 | | |
248 | 246 | | |
249 | 247 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
78 | 78 | | |
79 | 79 | | |
80 | 80 | | |
81 | | - | |
| 81 | + | |
82 | 82 | | |
83 | 83 | | |
84 | 84 | | |
| |||
0 commit comments