Skip to content

Commit 1fe8883

Browse files
committed
Avoid hardcoding the product name ins scripts and other source files
1 parent 0c39187 commit 1fe8883

36 files changed

Lines changed: 309 additions & 279 deletions

.github/workflows/pr-builder.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -611,7 +611,7 @@ jobs:
611611
run: |
612612
cd tests/e2e/thunder-server
613613
./setup.sh
614-
THUNDER_SKIP_SECURITY=true ./start.sh &
614+
SKIP_SECURITY=true ./start.sh &
615615
THUNDER_PID=$!
616616
echo "THUNDER_PID=$THUNDER_PID" >> $GITHUB_ENV
617617
# Wait for server to be ready

.github/workflows/windows-build-validation.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -279,7 +279,7 @@ jobs:
279279
shell: bash
280280
run: |
281281
cd tests/e2e/thunder-server
282-
THUNDER_SKIP_SECURITY=true ./thunder.exe > thunder-server.log 2>&1 &
282+
SKIP_SECURITY=true ./thunder.exe > thunder-server.log 2>&1 &
283283
echo "THUNDER_PID=$!" >> $GITHUB_ENV
284284
sleep 5
285285

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
# under the License.
1717
# ----------------------------------------------------------------------------
1818

19-
# Thunder Docker Image
19+
# Product Docker Image
2020
# Build stage - compile the Go binary and build frontend for the target architecture
2121
FROM golang:1.26-alpine3.23 AS builder
2222

Makefile

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
VERSION_FILE=version.txt
2121
VERSION=$(shell cat $(VERSION_FILE))
2222
BINARY_NAME=thunder
23+
PRODUCT_NAME=Thunder
2324

2425
export WITHOUT_CONSENT ?= false
2526

@@ -109,19 +110,19 @@ run_docs:
109110
./build.sh run_docs
110111

111112
docker-build:
112-
docker build -t thunder:$(VERSION) .
113+
docker build -t $(BINARY_NAME):$(VERSION) .
113114

114115
docker-build-latest:
115-
docker build -t thunder:latest .
116+
docker build -t $(BINARY_NAME):latest .
116117

117118
docker-build-multiarch:
118-
docker buildx build --platform linux/amd64,linux/arm64 -t thunder:$(VERSION) .
119+
docker buildx build --platform linux/amd64,linux/arm64 -t $(BINARY_NAME):$(VERSION) .
119120

120121
docker-build-multiarch-latest:
121-
docker buildx build --platform linux/amd64,linux/arm64 -t thunder:latest .
122+
docker buildx build --platform linux/amd64,linux/arm64 -t $(BINARY_NAME):latest .
122123

123124
docker-build-multiarch-push:
124-
docker buildx build --platform linux/amd64,linux/arm64 -t thunder:$(VERSION) -t thunder:latest --push .
125+
docker buildx build --platform linux/amd64,linux/arm64 -t $(BINARY_NAME):$(VERSION) -t $(BINARY_NAME):latest --push .
125126

126127
lint: lint_backend lint_frontend
127128

@@ -152,7 +153,7 @@ help:
152153
@echo " all - Clean, build, and test the project."
153154
@echo " backend - Clean, build, and test only the backend."
154155
@echo " clean - Remove build artifacts."
155-
@echo " build - Build Thunder (backend + frontend + samples)."
156+
@echo " build - Build $(PRODUCT_NAME) (backend + frontend + samples)."
156157
@echo " build_backend - Build the backend Go application."
157158
@echo " build_frontend - Build the frontend applications."
158159
@echo " build_docs - Build the documentation."
@@ -163,9 +164,9 @@ help:
163164
@echo " build_with_coverage - Build with coverage flags, run unit and integration tests, and generate combined coverage report."
164165
@echo " build_with_coverage_only - Build with coverage instrumentation (unit tests only, no integration tests)."
165166
@echo " test - Run all tests (unit and integration)."
166-
@echo " run - Build and run the Thunder server locally."
167-
@echo " run_backend - Build and run the Thunder backend locally."
168-
@echo " debug_backend - Build and run the Thunder backend locally in debug mode."
167+
@echo " run - Build and run the $(PRODUCT_NAME) server locally."
168+
@echo " run_backend - Build and run the $(PRODUCT_NAME) backend locally."
169+
@echo " debug_backend - Build and run the $(PRODUCT_NAME) backend locally in debug mode."
169170
@echo " run_frontend - Build and run the frontend applications locally."
170171
@echo " run_docs - Run the documentation development server with live reload."
171172
@echo " docker-build - Build single-arch Docker image with version tag."

backend/README.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,3 @@
1-
# Project Thunder Backend
1+
# Thunder Backend ⚡
2+
3+
Backend workspace for **Thunder ⚡** - a modern identity management suite. This workspace is built with Go and contains the core server implementation, API handlers, business logic, and integration with databases and other services for the Thunder platform.

backend/cmd/server/bootstrap/01-default-resources.ps1

Lines changed: 41 additions & 39 deletions
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)