587: Windows use .dll

Author: asgrim

src/DependencyResolver/Package.php

@@ -279,10 +279,10 @@ public function installedJsonMetadata(): InstalledJsonMetadata
     public function verifyPackageStatus(TargetPlatform $targetPlatform): PackageVerificationStatus
     {
         $extensionPath    = $targetPlatform->phpBinaryPath->extensionPath();
-        $extensionEnding  = $targetPlatform->operatingSystem === OperatingSystem::Windows ? '.dll' : '.so';
+        $isWindows        = $targetPlatform->operatingSystem === OperatingSystem::Windows;
         $phpExtensionName = $this->extensionName->name();
 
-        $actualBinaryPathByConvention = $extensionPath . DIRECTORY_SEPARATOR . $phpExtensionName . $extensionEnding;
+        $actualBinaryPathByConvention = $extensionPath . DIRECTORY_SEPARATOR . ($isWindows ? 'php_' : '') . $phpExtensionName . ($isWindows ? '.dll' : '.so');
 
         // The extension may not be in the usual path (since you can specify a full path to an extension in the INI file)
         if (! file_exists($actualBinaryPathByConvention)) {

test/integration/ComposerIntegration/ComposerIntegrationHandlerTest.php

@@ -20,10 +20,12 @@
 use Php\Pie\DependencyResolver\RequestedPackageAndVersion;
 use Php\Pie\DependencyResolver\ResolvedPackageRequest;
 use Php\Pie\Platform;
+use Php\Pie\Platform\OperatingSystem;
 use Php\Pie\Platform\TargetPhp\PhpBinaryPath;
 use Php\Pie\Platform\TargetPlatform;
 use Php\PieIntegrationTest\Command\IsolatedWorkingDirectoryTestCase;
 use PHPUnit\Framework\Attributes\CoversClass;
+use PHPUnit\Framework\Attributes\RequiresOperatingSystemFamily;
 use Symfony\Component\Console\Output\BufferedOutput;
 
 use function file_exists;
@@ -117,6 +119,7 @@ public function testRunInstallSkipsAlreadyVerifiedPackageAtSameVersion(): void
         self::assertStringContainsString('Nothing to install, update or remove', $output);
     }
 
+    #[RequiresOperatingSystemFamily('Linux')]
     public function testRunInstallReinstallsVerifiedPackageWhenVersionDiffers(): void
     {
         PieJsonEditor::fromTargetPlatform($this->targetPlatform)
@@ -169,7 +172,9 @@ public function testRunUninstallRemovesPackageFromPieJson(): void
 
     private function extensionBinaryPath(): string
     {
-        return $this->targetPlatform->phpBinaryPath->extensionPath() . DIRECTORY_SEPARATOR . self::EXTENSION_NAME . '.so';
+        $isWindows = $this->targetPlatform->operatingSystem === OperatingSystem::Windows;
+
+        return $this->targetPlatform->phpBinaryPath->extensionPath() . DIRECTORY_SEPARATOR . ($isWindows ? 'php_' : '') . self::EXTENSION_NAME . ($isWindows ? '.dll' : '.so');
     }
 
     /** @param non-empty-string $version */