615: don't use env. template expansions

Author: asgrim

.github/workflows/build-assets.yml

@@ -132,19 +132,26 @@ jobs:
           echo "PIE_BINARY_OUTPUT=pie-${{ runner.os }}-${{ runner.arch }}.exe" >> $env:GITHUB_ENV
 
       - name: Check SPC version
-        run: ${{ env.SPC_BINARY }} --version
+        env:
+          SPC_BINARY: ${{ env.SPC_BINARY }}
+        run: ${SPC_BINARY} --version
 
       - name: Grab the pie.phar from artifacts
         uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c #v8.0.1
         with:
           name: pie-${{ github.sha }}.phar
 
       - name: Build for ${{ runner.os }} ${{ runner.arch }} on ${{ matrix.operating-system }}
-        run: ${{ env.SPC_BINARY }} craft resources/spc/craft.yml
+        run: ${SPC_BINARY} craft resources/spc/craft.yml
         env:
+          SPC_BINARY: ${{ env.SPC_BINARY }}
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+
       - name: Bundle pie.phar into executable PIE binary
-        run: ${{ env.SPC_BINARY }} micro:combine pie.phar --output=${{ env.PIE_BINARY_OUTPUT }}
+        env:
+          PIE_BINARY_OUTPUT: ${{ env.PIE_BINARY_OUTPUT }}
+          SPC_BINARY: ${{ env.SPC_BINARY }}
+        run: ${SPC_BINARY} micro:combine pie.phar --output=${PIE_BINARY_OUTPUT}
 
       - name: Setup PHP
         uses: shivammathur/setup-php@f3e473d116dcccaddc5834248c87452386958240 #2.37.2
@@ -153,7 +160,9 @@ jobs:
           tools: composer
           php-version: "7.4"
       - name: Quick validation that the binary runs
-        run: ./${{ env.PIE_BINARY_OUTPUT }} show --all
+        env:
+          PIE_BINARY_OUTPUT: ${{ env.PIE_BINARY_OUTPUT }}
+        run: ./${PIE_BINARY_OUTPUT} show --all
 
       - name: Generate build provenance attestation
         # It does not make sense to do this for PR builds, nor do contributors
@@ -164,7 +173,7 @@ jobs:
         if: github.event_name != 'pull_request' && github.event.repository.visibility == 'public'
         uses: actions/attest@59d89421af93a897026c735860bf21b6eb4f7b26 #v4.1.0
         with:
-          subject-path: '${{ github.workspace }}/${{ env.PIE_BINARY_OUTPUT }}'
+          subject-path: ${{ github.workspace }}/${{ env.PIE_BINARY_OUTPUT }}
 
       - uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a #v7.0.1
         with:

.github/workflows/continuous-integration.yml

@@ -104,12 +104,14 @@ jobs:
           DIST_URL=`curl -fsSL "https://www.php.net/releases/index.php?json&max=1&version=${{ matrix.php-versions }}" | jq -r '.[].source[]|select(.filename|endswith(".gz")).filename'`
           echo "php_src_download_url=https://www.php.net/distributions/$DIST_URL" >> $GITHUB_ENV
       - name: "Install PHP ${{ matrix.php-versions }}"
+        env:
+          php_src_download_url: ${{ env.php_src_download_url }}
         run: |
           mkdir -p /tmp/php
           mkdir -p /tmp/php.ini.d
           cd /tmp/php
-          echo "Downloading release from ${{ env.php_src_download_url }} ..."
-          wget -O php.tgz ${{ env.php_src_download_url }}
+          echo "Downloading release from ${php_src_download_url} ..."
+          wget -O php.tgz ${php_src_download_url}
           tar zxf php.tgz
           rm php.tgz
           ls -l