only skip before_transactin in helper

the other hooks are run as part of the action itself
and have their own validity checks

Author: barnabasJ

lib/ash/actions/create/bulk.ex

@@ -487,14 +487,6 @@ defmodule Ash.Actions.Create.Bulk do
       else
         batch
       end
-      |> Enum.reject(fn
-        %{valid?: false} = changeset ->
-          store_error(ref, changeset, opts)
-          true
-
-        _changeset ->
-          false
-      end)
 
     {batch, must_be_simple_results} =
       batch

lib/ash/actions/destroy/bulk.ex

@@ -1439,14 +1439,6 @@ defmodule Ash.Actions.Destroy.Bulk do
       else
         batch
       end
-      |> Enum.reject(fn
-        %{valid?: false} = changeset ->
-          store_error(ref, changeset, opts)
-          true
-
-        _changeset ->
-          false
-      end)
 
     {batch, must_be_simple_results} =
       Ash.Actions.Helpers.split_and_run_simple(

lib/ash/actions/helpers.ex

@@ -17,7 +17,13 @@ defmodule Ash.Actions.Helpers do
       Enum.reduce(batch, {[], []}, fn changeset, {batch, must_be_simple} ->
         if changeset.around_transaction in [[], nil] and changeset.after_transaction in [[], nil] and
              changeset.around_action in [[], nil] do
-          changeset = Ash.Changeset.run_before_transaction_hooks(changeset)
+          changeset =
+            if changeset.valid? do
+              Ash.Changeset.run_before_transaction_hooks(changeset)
+            else
+              changeset
+            end
+
           {[changeset | batch], must_be_simple}
         else
           {batch, [%{changeset | __validated_for_action__: action.name} | must_be_simple]}

lib/ash/actions/update/bulk.ex

@@ -1757,14 +1757,6 @@ defmodule Ash.Actions.Update.Bulk do
       else
         batch
       end
-      |> Enum.reject(fn
-        %{valid?: false} = changeset ->
-          store_error(ref, changeset, opts)
-          true
-
-        _changeset ->
-          false
-      end)
 
     {batch, must_be_simple_results} =
       Ash.Actions.Helpers.split_and_run_simple(