use related? instead of unrelated?

Author: zachdaniel

lib/ash/expr/expr.ex

@@ -775,7 +775,7 @@ defmodule Ash.Expr do
           resource: Macro.escape(unquote(alias_ast)),
           expr: unquote(processed_expr),
           at_path: [],
-          unrelated?: true
+          related?: false
         }
       end,
       escape?
@@ -790,7 +790,7 @@ defmodule Ash.Expr do
           resource: Macro.escape(unquote(alias_ast)),
           expr: true,
           at_path: [],
-          unrelated?: true
+          related?: false
         }
       end,
       escape?
@@ -810,7 +810,7 @@ defmodule Ash.Expr do
             resource: unquote(module_atom),
             expr: unquote(processed_expr),
             at_path: [],
-            unrelated?: true
+            related?: false
           }
         end,
         escape?
@@ -830,7 +830,7 @@ defmodule Ash.Expr do
           resource: module_atom,
           expr: true,
           at_path: [],
-          unrelated?: true
+          related?: false
         },
         escape?
       )

lib/ash/filter/runtime.ex

@@ -542,23 +542,15 @@ defmodule Ash.Filter.Runtime do
            at_path: [],
            path: path,
            expr: expr,
-           unrelated?: unrelated?,
+           related?: related?,
            resource: unrelated_resource
          },
          record,
          parent,
          resource,
          unknown_on_unknown_refs?
        ) do
-    if unrelated? do
-      resolve_unrelated_exists(
-        unrelated_resource,
-        expr,
-        record,
-        parent,
-        unknown_on_unknown_refs?
-      )
-    else
+    if related? do
       record
       |> flatten_relationships([path])
       |> load_unflattened(path)
@@ -589,6 +581,14 @@ defmodule Ash.Filter.Runtime do
             end
           end)
       end
+    else
+      resolve_unrelated_exists(
+        unrelated_resource,
+        expr,
+        record,
+        parent,
+        unknown_on_unknown_refs?
+      )
     end
   end
 

lib/ash/query/function/exists.ex

@@ -3,7 +3,7 @@ defmodule Ash.Query.Exists do
   Determines if a given related entity exists.
   """
 
-  defstruct [:path, :expr, :resource, at_path: [], unrelated?: false, input?: false]
+  defstruct [:path, :expr, :resource, at_path: [], related?: true, input?: false]
 
   def new(path, expr, at_path \\ [])
 
@@ -25,14 +25,14 @@ defmodule Ash.Query.Exists do
     import Inspect.Algebra
 
     def inspect(
-          %{path: path, expr: expr, at_path: at_path, unrelated?: unrelated?, resource: resource},
+          %{path: path, expr: expr, at_path: at_path, related?: related?, resource: resource},
           opts
         ) do
       path_or_resource =
-        if unrelated? && resource do
-          inspect(resource)
-        else
+        if related? do
           Enum.join(path, ".")
+        else
+          inspect(resource)
         end
 
       if at_path && at_path != [] do

test/resource/unrelated_exists_test.exs

@@ -554,12 +554,12 @@ defmodule Ash.Test.Resource.UnrelatedExistsTest do
         )
 
       # Should parse without errors
-      assert %Ash.Query.Exists{unrelated?: true} = expr_ast
+      assert %Ash.Query.Exists{related?: false} = expr_ast
 
       # The inner structure should contain a nested unrelated exists
       assert %Ash.Query.BooleanExpression{
                right: %Ash.Query.Exists{
-                 unrelated?: true,
+                 related?: false,
                  resource: Ash.Test.Resource.UnrelatedExistsTest.Report
                }
              } = expr_ast.expr