chore: raise errors when a value fails to cast or dump

Author: zachdaniel

lib/ash/error/unknown/invalid_casted_value.ex

@@ -0,0 +1,9 @@
+defmodule Ash.Error.Unknown.InvalidCastedValue do
+  @moduledoc "Used when a value fails to dump to its native (storage) format"
+
+  use Splode.Error, fields: [:type, :value, :constraints, :error], class: :unknown
+
+  def message(%{type: type, value: value, error: error}) do
+    "Failed to dump #{inspect(type)} value #{inspect(value)}: #{inspect(error)}"
+  end
+end

lib/ash/error/unknown/invalid_stored_value.ex

@@ -0,0 +1,9 @@
+defmodule Ash.Error.Unknown.InvalidStoredValue do
+  @moduledoc "Used when a stored value fails to be cast from the data layer"
+
+  use Splode.Error, fields: [:type, :value, :constraints, :error], class: :unknown
+
+  def message(%{type: type, value: value, error: error}) do
+    "Failed to load #{inspect(type)} value #{inspect(value)}: #{inspect(error)}"
+  end
+end

lib/ash/type/type.ex

@@ -1735,7 +1735,14 @@ defmodule Ash.Type do
             {:ok, value} ->
               {:ok, value}
 
-            _ ->
+            {:error, error} ->
+              raise Ash.Error.Unknown.InvalidStoredValue,
+                type: parent,
+                value: term,
+                constraints: params,
+                error: error
+
+            :error ->
               :error
           end
         end
@@ -1748,7 +1755,14 @@ defmodule Ash.Type do
             {:ok, value} ->
               {:ok, value}
 
-            _ ->
+            {:error, error} ->
+              raise Ash.Error.Unknown.InvalidCastedValue,
+                type: parent,
+                value: term,
+                constraints: params,
+                error: error
+
+            :error ->
               :error
           end
         end