fix: allow Ash @global_opts authorize? to accept boolean or nil

- Revert 7e34bbd change that  updated Ash @global_opts `authorize?` to only accept boolean.

fixes #2224

Author: chazwatkins

lib/ash.ex

@@ -58,7 +58,7 @@ defmodule Ash do
       doc: "The action to use, either an Action struct or the name of the action"
     ],
     authorize?: [
-      type: :boolean,
+      type: {:or, [:boolean, {:literal, nil}]},
       doc:
         "If an actor option is provided (even if it is `nil`), authorization happens automatically. If not, this flag can be used to authorize with no user."
     ],

test/actions/stream_test.exs

@@ -4,24 +4,53 @@ defmodule Ash.Test.Actions.StreamTest do
 
   alias Ash.Test.Domain, as: Domain
 
+  defmodule Author do
+    @moduledoc false
+    use Ash.Resource,
+      domain: Domain,
+      data_layer: Ash.DataLayer.Ets
+
+    ets do
+      private? true
+    end
+
+    actions do
+      default_accept :*
+      defaults [:read, :destroy, create: :*, update: :*]
+    end
+
+    attributes do
+      uuid_primary_key :id
+    end
+  end
+
   defmodule Post do
     @moduledoc false
-    use Ash.Resource, domain: Domain, data_layer: Ash.DataLayer.Ets
+    use Ash.Resource,
+      domain: Domain,
+      data_layer: Ash.DataLayer.Ets,
+      authorizers: [Ash.Policy.Authorizer]
 
     ets do
       private? true
     end
 
     actions do
       default_accept :*
-      defaults [:destroy, create: :*, update: :*]
+      defaults [:destroy, update: :*]
 
       read :read do
         primary? true
         pagination keyset?: true, offset?: true, required?: false
       end
 
       read :read_with_no_pagination
+
+      create :create do
+        primary? true
+
+        change relate_actor(:author, allow_nil?: true)
+      end
     end
 
     attributes do
@@ -30,6 +59,24 @@ defmodule Ash.Test.Actions.StreamTest do
 
       timestamps()
     end
+
+    relationships do
+      belongs_to :author, Author, public?: true
+    end
+
+    policies do
+      policy action_type(:read) do
+        authorize_if always()
+      end
+
+      policy action_type(:create) do
+        authorize_if always()
+      end
+
+      policy action_type(:update) do
+        authorize_if relates_to_actor_via(:author)
+      end
+    end
   end
 
   test "records can be streamed" do
@@ -122,4 +169,37 @@ defmodule Ash.Test.Actions.StreamTest do
 
     assert count == 7
   end
+
+  test "runs successfully when actor is provided without authorize? - Issue #2224" do
+    actor =
+      Author
+      |> Ash.Changeset.for_create(:create)
+      |> Ash.create!()
+
+    assert %Ash.BulkResult{
+             records: [
+               %{title: "updated"},
+               %{title: "updated"}
+             ]
+           } =
+             Ash.bulk_create!(
+               [%{title: "foo"}, %{title: "bar"}],
+               Post,
+               :create,
+               return_stream?: true,
+               return_records?: true,
+               actor: actor
+             )
+             |> Stream.map(fn {:ok, result} ->
+               result
+             end)
+             |> Ash.bulk_update!(
+               :update,
+               %{title: "updated"},
+               resource: Post,
+               strategy: :stream,
+               return_records?: true,
+               actor: actor
+             )
+  end
 end