fix: validate attribute_input_types keys are actual public attributes

Author: nallwhy

lib/resource/verifiers/verify_field_dependencies.ex

@@ -183,8 +183,13 @@ defmodule AshGraphql.Resource.Verifiers.VerifyFieldDependencies do
     input_types = AshGraphql.Resource.Info.attribute_input_types(dsl)
 
     if is_list(input_types) and input_types != [] do
+      # Only check keys that are actual public attributes. Non-attribute keys
+      # (e.g. relationships) are caught by VerifyFieldReferences as invalid.
+      attribute_names =
+        dsl |> Ash.Resource.Info.public_attributes() |> MapSet.new(& &1.name)
+
       Enum.reduce(input_types, warnings, fn {attr, _type}, acc ->
-        if MapSet.member?(visible, attr) do
+        if not MapSet.member?(attribute_names, attr) or MapSet.member?(visible, attr) do
           acc
         else
           [invisible_field_warning(resource, attr, "attribute_input_types") | acc]

lib/resource/verifiers/verify_field_references.ex

@@ -45,6 +45,7 @@ defmodule AshGraphql.Resource.Verifiers.VerifyFieldReferences do
     )
 
     validate_option(dsl, resource, :relationships, relationship_names, "relationship")
+    validate_option(dsl, resource, :attribute_input_types, attribute_names, "attribute")
 
     :ok
   end
@@ -88,6 +89,9 @@ defmodule AshGraphql.Resource.Verifiers.VerifyFieldReferences do
   defp get_option(dsl, :sortable_fields), do: AshGraphql.Resource.Info.sortable_fields(dsl)
   defp get_option(dsl, :filterable_fields), do: AshGraphql.Resource.Info.filterable_fields(dsl)
 
+  defp get_option(dsl, :attribute_input_types),
+    do: AshGraphql.Resource.Info.attribute_input_types(dsl)
+
   # relationships/1 in Info falls back to all public relationships when nil,
   # so we read the raw option to only validate when explicitly set by the user.
   defp get_option(dsl, :relationships) do

test/verify_field_references_test.exs

@@ -182,4 +182,27 @@ defmodule AshGraphql.VerifyFieldReferencesTest do
       assert :ok = VerifyFieldReferences.verify(dsl_state())
     end
   end
+
+  describe "attribute_input_types" do
+    test "raises for unknown attribute" do
+      dsl = set_graphql_option(dsl_state(), :attribute_input_types, nonexistent: :string)
+
+      assert_raise Spark.Error.DslError, ~r/`:nonexistent`.*attribute_input_types/s, fn ->
+        VerifyFieldReferences.verify(dsl)
+      end
+    end
+
+    test "raises for relationship name (not an attribute)" do
+      dsl = set_graphql_option(dsl_state(), :attribute_input_types, related: :string)
+
+      assert_raise Spark.Error.DslError, ~r/`:related`.*attribute_input_types/s, fn ->
+        VerifyFieldReferences.verify(dsl)
+      end
+    end
+
+    test "passes for valid attribute" do
+      dsl = set_graphql_option(dsl_state(), :attribute_input_types, name: :string)
+      assert :ok = VerifyFieldReferences.verify(dsl)
+    end
+  end
 end