Skip to content

Commit e1996c6

Browse files
authored
fix: change default playground interface (#319)
Previously, the default playground interface was set to `:playground` which uses graphql-playground. However, this uses a deprecated JavaScript API which means that it does not work on modern versions of chrome. It also seems that the library is no longer maintained, so the chances of this being fixed in a future release are slim. The result of this, is that tooltips do not disappear, making the application seem broken. Whilst this isn't a direct issue of this library, I think it gives a bad impression when things are broken out of the box. This commit changes the generated interface to graphiql (using the `:simple` interface). There is also an `:advanced` interface option, but that also points to an unmaintained library which didn't work out of the box. graphql/graphql-playground#1429
1 parent 2d90820 commit e1996c6

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

lib/igniter.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ if Code.ensure_loaded?(Igniter) do
194194
Absinthe.Plug.GraphiQL,
195195
schema: Module.concat(["#{inspect(schema_name)}"]),
196196
socket: Module.concat(["#{inspect(socket_name)}"]),
197-
interface: :playground
197+
interface: :simple
198198
199199
forward "/",
200200
Absinthe.Plug,

test/mix/tasks/ash_graphql_install_test.exs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ defmodule Mix.Tasks.AshGraphqlInstallTest do
133133
+ | forward("/playground", Absinthe.Plug.GraphiQL,
134134
+ | schema: Module.concat(["TestWeb.GraphqlSchema"]),
135135
+ | socket: Module.concat(["TestWeb.GraphqlSocket"]),
136-
+ | interface: :playground
136+
+ | interface: :simple
137137
+ | )
138138
+ |
139139
+ | forward("/", Absinthe.Plug, schema: Module.concat(["TestWeb.GraphqlSchema"]))

0 commit comments

Comments
 (0)