test: add tests for after_transaction hook batch change callbacks

Author: zachdaniel

lib/resource/changes/create_new_version.ex

@@ -280,10 +280,12 @@ defmodule AshPaperTrail.Resource.Changes.CreateNewVersion do
       domain: changeset.domain,
       stop_on_error?: true,
       return_errors?: true,
+      return_records?: true,
       skip_unknown_inputs: Enum.flat_map(inputs, &Map.keys(&1))
     ]
 
-    Ash.bulk_create!(inputs, version_changeset.resource, :create, opts)
+    inputs
+    |> Ash.bulk_create!(version_changeset.resource, :create, opts)
     |> Map.get(:notifications)
   end
 

test/ash_paper_trail_test.exs

@@ -168,6 +168,35 @@ defmodule AshPaperTrailTest do
                |> Enum.sort_by(& &1.version_action_type)
     end
 
+    test "a new version is created on a bulk update with enumerable and after_transaction" do
+      %{subject: "subject", body: "body", id: post_id} =
+        post = Posts.Post.create!(@valid_attrs, tenant: "acme")
+
+      %Ash.BulkResult{
+        status: :success
+      } =
+        Ash.bulk_update!([post], :publish, %{},
+          tenant: "acme",
+          strategy: :stream,
+          return_records?: true,
+          return_errors?: true
+        )
+
+      assert [
+               _,
+               %{
+                 changes: %{
+                   published: true
+                 },
+                 version_action_type: :update,
+                 version_action_name: :publish,
+                 version_source_id: ^post_id
+               }
+             ] =
+               Ash.read!(Posts.Post.Version, tenant: "acme")
+               |> Enum.sort_by(& &1.version_action_type)
+    end
+
     test "a new version is created on a bulk update with query" do
       %{subject: "subject", body: "body", id: post_id} =
         Posts.Post.create!(@valid_attrs, tenant: "acme")

test/support/posts/post.ex

@@ -44,6 +44,10 @@ defmodule AshPaperTrail.Test.Posts.Post do
       require_atomic? false
       accept []
       change set_attribute(:published, true)
+
+      change after_transaction(fn _changeset, res, _ ->
+               res
+             end)
     end
   end