fix: test setup

Author: pcapel

test/aggregate_test.exs

@@ -2267,6 +2267,21 @@ defmodule AshSql.AggregateTest do
       # an Ash.Filter struct as an operand, the private do_dynamic_expr/default_dynamic_expr
       # functions don't have a clause to handle it, so the Ash.Filter is passed directly
       # to Ecto instead of being converted to a dynamic expression.
+      #
+      # The bug triggers when authorization policies create Ash.Filter structs that get
+      # combined with join_filter expressions in BooleanExpressions.
+
+      # Set up authorization chain: User -> Organization -> Post -> Comment
+      org =
+        Organization
+        |> Ash.Changeset.for_create(:create, %{name: "Test Org"})
+        |> Ash.create!()
+
+      user =
+        User
+        |> Ash.Changeset.for_create(:create, %{})
+        |> Ash.Changeset.manage_relationship(:organization, org, type: :append_and_remove)
+        |> Ash.create!()
 
       author =
         Author
@@ -2276,6 +2291,7 @@ defmodule AshSql.AggregateTest do
       post =
         Post
         |> Ash.Changeset.for_create(:create, %{title: "test"})
+        |> Ash.Changeset.manage_relationship(:organization, org, type: :append_and_remove)
         |> Ash.Changeset.manage_relationship(:author, author, type: :append_and_remove)
         |> Ash.create!()
 
@@ -2293,15 +2309,17 @@ defmodule AshSql.AggregateTest do
 
       # This triggers the bug - loading a calculation that uses join_filters with actor reference.
       # The join_filter `expr(author_id == ^actor(:id))` gets resolved to an Ash.Filter struct
-      # which is then combined with other filters in a BooleanExpression.
-      # We use authorize?: false to bypass Post's organization-based authorization policies.
+      # which is then combined with authorization policy filters in a BooleanExpression.
       assert {:ok, [loaded_post]} =
                Post
                |> Ash.Query.filter(id == ^post.id)
                |> Ash.Query.load(:max_rating_with_join_filter)
-               |> Ash.read(actor: author, authorize?: false)
+               |> Ash.read(actor: user)
 
-      assert loaded_post.max_rating_with_join_filter == 10
+      # The rating won't match because the comment's author_id doesn't match user.id,
+      # but the important thing is the query executes without CastError
+      assert is_nil(loaded_post.max_rating_with_join_filter) or
+               loaded_post.max_rating_with_join_filter == 10
     end
   end
 end