fix: don't use Code.ensure_compiled

Author: zachdaniel

lib/mix/tasks/spark.formatter.ex

@@ -28,27 +28,6 @@ if Code.ensure_loaded?(Sourceror) do
 
       locals_without_parens =
         Enum.flat_map(extensions, fn extension_mod ->
-          case Code.ensure_compiled(extension_mod) do
-            {:module, _module} ->
-              :ok
-
-            other ->
-              error_msg =
-                if Mix.Project.umbrella?() do
-                  """
-                  Error ensuring extension compiled: #{inspect(other)}
-
-                  You are running this task from an umbrella project root.
-                  Try running this task from within a sub-app directory, or compile the project first:
-                    cd apps/<your_app> && mix spark.formatter --extensions #{opts[:extensions]}
-                  """
-                else
-                  "Error ensuring extension compiled #{inspect(other)}"
-                end
-
-              raise error_msg
-          end
-
           all_entity_builders_everywhere(
             extension_mod.sections(),
             extension_mod.dsl_patches(),

lib/spark/formatter.ex

@@ -103,7 +103,7 @@ if Code.ensure_loaded?(Sourceror) do
           false ->
             case get_extensions(body, config) do
               {:ok, extensions, type, using} ->
-                replacement = format_resource(body, extensions, config, type, using)
+                replacement = format_resource(body, extensions, config, type, using, opts)
 
                 patches =
                   body
@@ -135,7 +135,7 @@ if Code.ensure_loaded?(Sourceror) do
       patches
     end
 
-    defp format_resource(body, extensions, config, _type, using) do
+    defp format_resource(body, extensions, config, _type, using, opts) do
       sections =
         extensions
         |> Enum.flat_map(fn extension ->
@@ -179,14 +179,14 @@ if Code.ensure_loaded?(Sourceror) do
       |> Enum.map(&elem(&1, 0))
       |> then(fn sections ->
         if config[:remove_parens?] do
-          de_paren(sections, Enum.flat_map(extensions, & &1.sections()), extensions)
+          de_paren(sections, Enum.flat_map(extensions, & &1.sections()), extensions, opts)
         else
           sections
         end
       end)
     end
 
-    defp de_paren(actual_sections, dsl_sections, extensions) do
+    defp de_paren(actual_sections, dsl_sections, extensions, opts) do
       actual_sections
       |> Enum.map(fn
         {name, meta, body} ->
@@ -195,16 +195,18 @@ if Code.ensure_loaded?(Sourceror) do
               {name, meta, body}
 
             section ->
-              {name, meta, de_paren_section(body, section, extensions)}
+              {name, meta, de_paren_section(body, section, extensions, opts)}
           end
 
         other ->
           other
       end)
     end
 
-    defp de_paren_section(body, section, extensions) do
-      builders = all_entity_builders([section], extensions)
+    defp de_paren_section(body, section, extensions, opts) do
+      locals_without_parens = Keyword.get(opts, :locals_without_parens, [])
+
+      builders = all_entity_builders([section], extensions) ++ locals_without_parens
 
       Macro.prewalk(body, fn
         {func, meta, body} = node when is_atom(func) ->
@@ -285,14 +287,13 @@ if Code.ensure_loaded?(Sourceror) do
             []
         end
         |> List.wrap()
+        |> Enum.filter(&is_atom/1)
         |> Enum.flat_map(fn extension ->
-          case is_atom(extension) and Code.ensure_compiled(extension) do
-            {:module, module} ->
-              if Spark.implements_behaviour?(module, Spark.Dsl.Extension) do
-                [module]
-              else
-                []
-              end
+          if Code.ensure_loaded?(module) and Spark.implements_behaviour?(module, Spark.Dsl.Extension) do
+            [module]
+          else
+            []
+          end
 
             _ ->
               []