Skip to content

Commit 20e61b8

Browse files
authored
chore: switch default vllm port from 8001 to 8200 for sidecar (llm-d#1723)
- remove explicitly config to use 8200 in deployment and test - keep local dev test with 8001 Signed-off-by: Wen Zhou <wenzhou@redhat.com>
1 parent ccd30ba commit 20e61b8

7 files changed

Lines changed: 4 additions & 9 deletions

File tree

deploy/components/vllm-decode/deployment.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ spec:
2525
imagePullPolicy: IfNotPresent
2626
args:
2727
- "--port=8000"
28-
- "--vllm-port=8200"
2928
- "--secure-proxy=false"
3029
- "--data-parallel-size=${VLLM_DATA_PARALLEL_SIZE}"
3130
ports:

deploy/environments/dev/e-p-d/patch-decode.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ spec:
1212
- name: routing-sidecar
1313
args:
1414
- "--port=8000"
15-
- "--vllm-port=8200"
1615
- "--kv-connector=${KV_CONNECTOR_TYPE}"
1716
- "--ec-connector=${EC_CONNECTOR_TYPE}"
1817
- "--secure-proxy=false"

deploy/environments/dev/e-pd/patch-decode.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ spec:
1212
- name: routing-sidecar
1313
args:
1414
- "--port=8000"
15-
- "--vllm-port=8200"
1615
- "--ec-connector=${EC_CONNECTOR_TYPE}"
1716
- "--secure-proxy=false"
1817
- "--data-parallel-size=${VLLM_DATA_PARALLEL_SIZE}"

deploy/environments/dev/p-d/patch-decode.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ spec:
1212
- name: routing-sidecar
1313
args:
1414
- "--port=8000"
15-
- "--vllm-port=8200"
1615
- "--kv-connector=${CONNECTOR_TYPE}"
1716
- "--mooncake-bootstrap-port=8000"
1817
- "--secure-proxy=false"

pkg/sidecar/proxy/options.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ const (
8989

9090
// Defaults
9191
defaultPort = "8000"
92-
defaultVLLMPort = "8001"
92+
defaultVLLMPort = "8200"
9393
defaultDataParallelSize = 1
9494
defaultMooncakeBootstrapPort = 8998
9595

pkg/sidecar/proxy/options_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ func createConfigWithValidYAML(t *testing.T) string {
4343
t.Helper()
4444
return writeTempYAML(t, "valid.yaml", fmt.Sprintf(`
4545
port: 8100
46-
vllm-port: 8200
46+
vllm-port: 8001
4747
data-parallel-size: 5
4848
kv-connector: %q
4949
connector: %q
@@ -74,7 +74,7 @@ func createConfigWithUnknownKeys(t *testing.T) string {
7474
t.Helper()
7575
return writeTempYAML(t, "valid.yaml", `
7676
port: 8100
77-
vllm-port: 8200
77+
vllm-port: 8001
7878
unknown-key: 1001
7979
`)
8080
}
@@ -183,7 +183,7 @@ func TestSidecarConfiguration(t *testing.T) {
183183
},
184184
expected: func(o *Options) {
185185
o.Port = "8100"
186-
o.vllmPort = "8200"
186+
o.vllmPort = "8001"
187187
o.DataParallelSize = 5
188188
o.MaxIdleConnsPerHost = 300
189189
o.MooncakeBootstrapPort = 9000

test/sidecar/config/nixl/qwen-decoder-pod.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ spec:
2525
runAsNonRoot: true
2626
args:
2727
- "-port=8000"
28-
- "-vllm-port=8200"
2928
- "-connector=nixlv2"
3029
- "-v=6"
3130
ports:

0 commit comments

Comments
 (0)