chore: reduce usage of global keyword (#295)

Author: ashishb

adbe/adb_helper.py

@@ -1,3 +1,4 @@
+import dataclasses
 import functools
 import subprocess
 
@@ -10,6 +11,13 @@
     from output_helper import print_error, print_error_and_exit, print_verbose
 
 
+@dataclasses.dataclass
+class _Settings:
+    adb_prefix: str = "adb"
+
+
+__settings = _Settings()
+
 _adb_prefix = "adb"
 _IGNORED_LINES = [
     "WARNING: linker: libdvm.so has text relocations. This is wasting memory and is a security risk. Please fix.",
@@ -20,13 +28,11 @@
 
 
 def get_adb_prefix() -> str:
-    return _adb_prefix
+    return __settings.adb_prefix
 
 
 def set_adb_prefix(adb_prefix: str) -> None:
-    # pylint: disable=global-statement
-    global _adb_prefix
-    _adb_prefix = adb_prefix
+    __settings.adb_prefix = adb_prefix
 
 
 def get_adb_shell_property(property_name: str, device_serial=None) -> str | None:

adbe/output_helper.py

@@ -1,11 +1,19 @@
+import dataclasses
+import functools
 import sys
 
-__VERBOSE_MODE: bool = False
+
+@dataclasses.dataclass
+class _Settings:
+    """Settings for the output helper."""
+    verbose: bool = False
+
+
+__settings = _Settings()
 
 
 def set_verbose(*, enabled: bool) -> None:
-    global __VERBOSE_MODE
-    __VERBOSE_MODE = enabled
+    __settings.verbose = enabled
 
 
 def print_message(message: str) -> None:
@@ -25,12 +33,13 @@ def print_error(error_string: str) -> None:
 
 
 def print_verbose(message: str) -> None:
-    if __VERBOSE_MODE and _is_interactive_terminal():
+    if __settings.verbose and _is_interactive_terminal():
         print(f"{BashColors.WARNING}{message}{BashColors.ENDC}")
     else:
         print(message)
 
 
+@functools.lru_cache
 def _is_interactive_terminal() -> bool:
     return sys.stdout.isatty()