That's quite cool how you use the learning network stuff to create the wrappers!
I've made some minor corrections on a fork: ablaom@d7f1d5c - mostly with regard to MLJBase 0.14 update
Suggestions:
-
Implement some checks (via clean! method) on the classifier, such as classifier isa Deterministic although you may want to handle Probabilisitic too, and just change predict to predict_mode, or have a probability- based re-weighting. Also, to ensure it's a classifier, you should check target_scitype(classifier) <: AbstractArray{<:Finite}.
-
I believe "reweighing" should be "reweighting" (despite auto-correction to the contrary). "to weight" (a data point) is a verb in this context, distinct from the related verb "to weigh" (an apple).
That's quite cool how you use the learning network stuff to create the wrappers!
I've made some minor corrections on a fork: ablaom@d7f1d5c - mostly with regard to MLJBase 0.14 update
Suggestions:
Implement some checks (via
clean!method) on the classifier, such asclassifier isa Deterministicalthough you may want to handleProbabilisitictoo, and just changepredicttopredict_mode, or have a probability- based re-weighting. Also, to ensure it's a classifier, you should checktarget_scitype(classifier) <: AbstractArray{<:Finite}.I believe "reweighing" should be "reweighting" (despite auto-correction to the contrary). "to weight" (a data point) is a verb in this context, distinct from the related verb "to weigh" (an apple).