Fix: Equality check on NEON (#197)

mdx1358 · web-flow · commit 705fb5edc230 · 2024-11-30T12:21:38.000Z
The `vmaxvq_u8` should be replaced with `vminvq_u8` 
to make the `sz_equal_neon` function actually work.
diff --git a/include/stringzilla/stringzilla.h b/include/stringzilla/stringzilla.h
@@ -5818,7 +5818,7 @@ SZ_PUBLIC sz_bool_t sz_equal_neon(sz_cptr_t a, sz_cptr_t b, sz_size_t length) {
         a_vec.u8x16 = vld1q_u8((sz_u8_t const *)a);
         b_vec.u8x16 = vld1q_u8((sz_u8_t const *)b);
         uint8x16_t cmp = vceqq_u8(a_vec.u8x16, b_vec.u8x16);
-        if (vmaxvq_u8(cmp) != 255) { return sz_false_k; } // Check if all bytes match
+        if (vminvq_u8(cmp) != 255) { return sz_false_k; } // Check if all bytes match
     }
 
     // Handle remaining bytes

Original file line number	Diff line number	Diff line change
`@@ -5818,7 +5818,7 @@ SZ_PUBLIC sz_bool_t sz_equal_neon(sz_cptr_t a, sz_cptr_t b, sz_size_t length) {`
`5818`	`5818`	`a_vec.u8x16 = vld1q_u8((sz_u8_t const *)a);`
`5819`	`5819`	`b_vec.u8x16 = vld1q_u8((sz_u8_t const *)b);`
`5820`	`5820`	`uint8x16_t cmp = vceqq_u8(a_vec.u8x16, b_vec.u8x16);`
`5821`		`- if (vmaxvq_u8(cmp) != 255) { return sz_false_k; } // Check if all bytes match`
	`5821`	`+ if (vminvq_u8(cmp) != 255) { return sz_false_k; } // Check if all bytes match`
`5822`	`5822`	`}`
`5823`	`5823`
`5824`	`5824`	`// Handle remaining bytes`