fixed inconsistent output issue (#58)

Author: ashiishme

src/BikramSambat.test.ts

@@ -93,6 +93,11 @@ describe('BikramSambat Class', () => {
       expect(bikramSambat.toAD().toISOString().slice(0, 10)).toBe(adDate)
     })
   })
+  it('should properly convert dates to BikramSambat using both instance and static methods', () => {
+    const bsDateFromInstance = new BikramSambat().toString()
+    const bsDateFromStaticMethod = BikramSambat.fromAD(new Date()).toString();
+    expect(bsDateFromInstance).toEqual(bsDateFromStaticMethod)
+  })
   it('should properly convert to BikramSambat Date', () => {
     sampleData.forEach(([bsDate, adDate]) => {
       expect(BikramSambat.fromAD(adDate).toString()).toBe(bsDate)

src/BikramSambat.ts

@@ -49,7 +49,7 @@ export class BikramSambat {
       this.month = dateStr.getMonth()
       this.day = dateStr.getDay()
     } else {
-      const currentDate = new Date().toISOString().slice(0, 10)
+      const currentDate = new Date()
       const currentBsDate = BikramSambat.fromAD(currentDate)
       this.year = currentBsDate.getYear()
       this.month = currentBsDate.getMonth()
@@ -181,10 +181,13 @@ export class BikramSambat {
     if (!date) {
       return new BikramSambat()
     }
+
     const gregorianDate = new Date(date)
-    if (gregorianDate.toString() === InvalidDate) {
+
+    if (isNaN(gregorianDate.getTime()) || gregorianDate.toString() === InvalidDate) {
       return new BikramSambat(InvalidDate)
     }
+
     const { newYearDate, bsYear } = getNewYearDateInfo(gregorianDate)
     const daysFromNewYear = getDaysBetweenTwoAdDates(
       gregorianDate,

src/index.ts

@@ -1,3 +1,3 @@
 import { BikramSambat } from './BikramSambat'
 
-export default BikramSambat
+export default BikramSambat

src/utils/getDaysBetweenTwoAdDates.test.ts

@@ -18,4 +18,11 @@ describe('getDaysBetweenTwoAdDates', () => {
     const endDate = new Date('2023-08-15')
     expect(getDaysBetweenTwoAdDates(startDate, endDate)).toBe(0)
   })
+
+  it('calculates the correct number of days ignoring partial days', () => {
+    const startDate = new Date();
+    const endDate = new Date();
+    endDate.setMinutes(startDate.getMinutes() + 5); // Add 5 minutes
+    expect(getDaysBetweenTwoAdDates(startDate, endDate)).toBe(0)
+  })
 })

src/utils/getDaysBetweenTwoAdDates.ts

@@ -2,6 +2,6 @@ const MILLISECONDS_IN_A_DAY = 1000 * 60 * 60 * 24
 
 export const getDaysBetweenTwoAdDates = (startDate: Date, endDate: Date) => {
   const timeDiff = Math.abs(endDate.getTime() - startDate.getTime())
-  const diffDays = Math.ceil(timeDiff / MILLISECONDS_IN_A_DAY)
+  const diffDays = Math.floor(timeDiff / MILLISECONDS_IN_A_DAY)
   return diffDays
 }