jump-by-word (^+right) goes too far when tabs are involved

[asottile]

compare the following press ^+right when cursor is at left edge depending on whether it's a tab or a space

   word-here
   ^    ^
   |    + tabs stop here
   + spaces stops here

[murtadapy]

I would like to take this issue, but I'm not totally sure if I get it right. May you please explain it a bit more?

[asottile]

^-right from beginning of the line goes to the wrong place when the line is indented with a tab -- it should go to the same position as if the line were indented with spaces

[murtadapy]

I couldn't reproduce this, it seems just the same for me. I tested it on the given example above and one on a random example

[asottile]

do you have an actual tab character?

[murtadapy]

Yes, I do. Probably I'm doing something wrong!

[asottile]

try these two (press ^Right after opening either of them)

babi +2 - <<< $'\n\thello world\n\n    hello world\n'
babi +4 - <<< $'\n\thello world\n\n    hello world\n'

[murtadapy]

First:

Second:

[asottile]

yeah see how they are not the same?

[murtadapy]

Oh, I get it now. That was so hard to notice for me!

[murtadapy]

I tried to run Pytest before changing anything just to ensure that everything is working fine before I start but I get the following for some reason:
E FileNotFoundError: [Errno 2] No such file or directory: 'tmux'

Also, I should not trust test_ctrl_right_jump_by_word after changing right?

[asottile]

going to assume you're new to software development -- usually the response to "No such file or directory: X" should be to figure out why you don't have X

the existing tests should all pass after your change

[murtadapy]

Clearly, the issue is from line 378 or it's because of the wrong value of comparison between tp and the current x. I tried to remove that and it was working fine for me, though I cannot ensure that will be right for all cases since I'm still not able to run the tests because of a problem with Hecate.

babi/babi/file.py

Lines 376 to 381 in c51484c

	# if we're inside the line, jump to next position that's not our type
	else:
	self.buf.right(dim)
	tp = line[self.buf.x].isalnum()
	while self.buf.x < len(line) and tp == line[self.buf.x].isalnum():
	self.buf.right(dim)