🎲 fix generating random quote/author ids

Author: Joshix-1

an_website/quotes/utils.py

@@ -81,9 +81,6 @@ class UltraDictType[K, V](MutableMapping[K, V], abc.ABC):
     UltraDict(buffer_size=1024**2, serializer=dill)
 )
 
-MAX_QUOTES_ID = Value("Q", 0)
-MAX_AUTHORS_ID = Value("Q", 0)
-
 
 @dataclass(init=False, slots=True)
 class QuotesObjBase(abc.ABC):
@@ -437,7 +434,6 @@ def parse_author(json_data: Mapping[str, Any]) -> Author:
         if author is None:
             # pylint: disable-next=too-many-function-args
             author = Author(id_, name, None)
-            MAX_AUTHORS_ID.value = max(MAX_AUTHORS_ID.value, id_)
         elif author.name != name:
             author.name = name
             author.info = None  # reset info
@@ -474,7 +470,6 @@ def parse_quote(
         if quote is None:  # new quote
             # pylint: disable=too-many-function-args
             quote = Quote(quote_id, quote_str, author.id)
-            MAX_QUOTES_ID.value = max(MAX_QUOTES_ID.value, quote.id)
         else:  # quote was already saved
             quote.quote = quote_str
             quote.author_id = author.id
@@ -795,12 +790,12 @@ async def get_rating_by_id(quote_id: int, author_id: int) -> int | None:
 
 def get_random_quote_id() -> int:
     """Get random quote id."""
-    return random.randint(1, MAX_QUOTES_ID.value)  # nosec: B311
+    return random.choice(tuple(QUOTES_CACHE))
 
 
 def get_random_author_id() -> int:
     """Get random author id."""
-    return random.randint(1, MAX_AUTHORS_ID.value)  # nosec: B311
+    return random.choice(tuple(AUTHORS_CACHE))
 
 
 def get_random_id() -> tuple[int, int]:

tests/test_quotes.py

@@ -71,10 +71,7 @@ async def test_parsing_wrong_quotes() -> None:
     assert await quotes.get_rating_by_id(1, 2) == 4
 
     assert len(quotes.QUOTES_CACHE) == 1
-    assert quotes.MAX_QUOTES_ID.value == 1
     assert len(quotes.AUTHORS_CACHE) == 2
-    assert quotes.MAX_AUTHORS_ID.value == 2
-
 
 def test_author_updating() -> None:
     """Test updating the author."""