chore(ci): enable buildifier check (#480)

Author: alexeagle

.aspect/workflows/bazelrc

@@ -1,3 +1,5 @@
+common --config=ci
+
 # build without the bytes
 common --remote_download_outputs=minimal
 common --nobuild_runfile_links

.aspect/workflows/config.yaml

@@ -1,8 +1,9 @@
 # See https://docs.aspect.build/workflows/configuration
 tasks:
-  - gazelle:
   - checkout:
       update_strategy: rebase
+  - gazelle:
+  - buildifier:
   - lint:
   - format:
   - test:

.bazelrc

@@ -11,8 +11,6 @@ common --check_direct_dependencies=off
 common --workspace_status_command=githooks/check-config.sh
 # But not on CI.
 common:ci --workspace_status_command=
-# Placeholder for your actual stamping logic
-build:release --workspace_status_command='echo BUILD_VERSION v1.2.3'
 
 # 'bazel build --config=lint' will produce the linter reports.
 build:lint --aspects=//tools/lint:linters.bzl%buf

.bazelversion

@@ -1,7 +1 @@
-8.2.0
-
-# The first line of this file is the version of Bazel that Bazelisk will
-# download. We use the latest version of Bazel because we rely on strong testing
-# the Bazel team performs on every LTS release.
-
-# More about Bazel's Long-Term Support model: https://bazel.build/release
+8.4.2

.circleci/config.yml

@@ -16,6 +16,9 @@ workflows:
         requires:
         - aw-test
         workspace: .
+    - aw-buildifier:
+        context: []
+        workspace: .
     - aw-format:
         context: []
         workspace: .
@@ -102,6 +105,50 @@ jobs:
         name: Delivery
         no_output_timeout: 180m
     working_directory: /mnt/ephemeral/workdir
+  aw-buildifier:
+    environment:
+      ASPECT_WORKFLOWS_CIRCLE_PIPELINE_NUMBER: << pipeline.number >>
+      ASPECT_WORKFLOWS_CIRCLE_PIPELINE_PROJECT_TYPE: << pipeline.project.type >>
+      ASPECT_WORKFLOWS_CIRCLE_WORKFLOW_BASE_NAME: aspect-workflows
+      ASPECT_WORKFLOWS_CONFIG: .aspect/workflows/config.yaml
+      ASPECT_WORKFLOWS_WORKSPACE: << parameters.workspace >>
+      XDG_CACHE_HOME: /mnt/ephemeral/caches
+    machine: true
+    parameters:
+      delivery_manifest:
+        default: true
+        type: boolean
+      workspace:
+        type: string
+    resource_class: aspect-build/aspect-default
+    steps:
+    - run:
+        command: /etc/aspect/workflows/bin/configure_workflows_env
+        name: Workflows environment
+    - checkout
+    - run:
+        command: rm -rf /workflows/artifacts /workflows/testlogs
+        name: Prepare archive directories
+    - run:
+        command: /etc/aspect/workflows/bin/agent_health_check
+        name: Agent health check
+        no_output_timeout: 180m
+    - run:
+        command: rosetta run checkout
+        name: Checkout health
+        no_output_timeout: 180m
+    - run:
+        command: rosetta run buildifier --workspace << parameters.workspace >>
+        name: Buildifier
+        no_output_timeout: 180m
+    - store_artifacts:
+        path: /workflows/artifacts
+    - run:
+        command: rosetta run finalization
+        name: Finalization
+        no_output_timeout: 10m
+        when: always
+    working_directory: /mnt/ephemeral/workdir
   aw-format:
     environment:
       ASPECT_WORKFLOWS_CIRCLE_PIPELINE_NUMBER: << pipeline.number >>

BUILD.bazel

@@ -1,4 +1,5 @@
 load("@aspect_rules_js//js:defs.bzl", "js_library")
+load("@buildifier_prebuilt//:rules.bzl", "buildifier")
 load("@gazelle//:def.bzl", "gazelle")
 load("@npm//:defs.bzl", "npm_link_all_packages")
 
@@ -76,3 +77,25 @@ alias(
     actual = "//tools/format:format",
     visibility = ["//visibility:public"],
 )
+
+buildifier(
+    name = "buildifier",
+    exclude_patterns = ["./.git/*"],
+    lint_mode = "fix",
+    mode = "fix",
+)
+
+# todo(team): burn down to zero
+DISABLED_BUILDIFIER_WARNINGS = [
+    "module-docstring",
+    "function-docstring",
+    "unused-variable",
+]
+
+buildifier(
+    name = "buildifier.check",
+    exclude_patterns = ["./.git/*"],
+    lint_mode = "warn",
+    lint_warnings = ["-{}".format(w) for w in DISABLED_BUILDIFIER_WARNINGS],
+    mode = "diff",
+)

MODULE.bazel

@@ -22,7 +22,7 @@ bazel_dep(name = "googletest", version = "1.15.2")
 bazel_dep(name = "platforms", version = "0.0.10")
 bazel_dep(name = "rules_angular", version = "0.1.0")
 bazel_dep(name = "rules_apple", version = "3.0.0")
-bazel_dep(name = "rules_buf", version = "0.3.0")
+bazel_dep(name = "rules_buf", version = "0.5.2")
 bazel_dep(name = "rules_cc", version = "0.1.1")
 bazel_dep(name = "rules_go", version = "0.56.1")
 bazel_dep(name = "rules_java", version = "8.6.1")

WORKSPACE.bazel

@@ -48,11 +48,11 @@ npm_translate_lock(
     custom_postinstalls = {
         "ng2-dragula": "ngcc --source .",
     },
+    npmrc = "//:.npmrc",
+    pnpm_lock = "//:pnpm-lock.yaml",
     # Workaround https://github.com/sass/dart-sass/issues/1765
     # See comments in sass_workaround.bzl
     public_hoist_packages = {p: ["packages/lib-a"] for p in SASS_DEPS},
-    npmrc = "//:.npmrc",
-    pnpm_lock = "//:pnpm-lock.yaml",
     verify_node_modules_ignored = "//:.bazelignore",
 )
 
@@ -73,6 +73,7 @@ http_archive(
 )
 
 v2_branch_head = "e5932f883443233f42b61d3fb87b2287518fbcba"
+
 http_archive(
     name = "aspect_rules_ts",
     #sha256 = "ace5b609603d9b5b875d56c9c07182357c4ee495030f40dcefb10d443ba8c208",

angular-ngc/WORKSPACE.bazel

@@ -1,13 +1,13 @@
-load("@bazel_skylib//rules:write_file.bzl", "write_file")
-load("@aspect_rules_js//npm:defs.bzl", "npm_package")
 load("@aspect_bazel_lib//lib:copy_to_directory.bzl", "copy_to_directory")
 load("@aspect_rules_esbuild//esbuild:defs.bzl", "esbuild")
+load("@aspect_rules_js//npm:defs.bzl", "npm_package")
+load("@bazel_skylib//rules:write_file.bzl", "write_file")
 load("@npm//:history-server/package_json.bzl", history_server_bin = "bin")
 load("@npm//:html-insert-assets/package_json.bzl", html_insert_assets_bin = "bin")
 load("@npm//:karma/package_json.bzl", _karma_bin = "bin")
+load("//tools:karma.bzl", "generate_karma_config", "generate_test_bootstrap", "generate_test_setup")
 load("//tools:ng.bzl", "ng_esbuild", "ng_project")
 load("//tools:ts.bzl", "ts_project")
-load("//tools:karma.bzl", "generate_karma_config", "generate_test_bootstrap", "generate_test_setup")
 
 # Common dependencies of Angular applications
 APPLICATION_DEPS = [