Skip to content

Commit f255214

Browse files
authored
chore: add Angular CLI to tools (#425)
- Update the rules_js version to pick up Bazel 8 rctx.watch fixes - Bump node.js version as required by Angular CLI - Switch to alias pattern for _run_under_cwd.sh like our 'aspect init' template now has Prefactoring for stamping out a new Angular example
1 parent d1db059 commit f255214

File tree

9 files changed

+1372
-31
lines changed

9 files changed

+1372
-31
lines changed

.aspect/bazelrc/performance.bazelrc

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,6 @@
55
# Docs: https://bazel.build/reference/command-line-reference#flag--reuse_sandbox_directories
66
build --experimental_reuse_sandbox_directories
77

8-
# Do not build runfiles symlink forests for external repositories under
9-
# `.runfiles/wsname/external/repo` (in addition to `.runfiles/repo`). This reduces runfiles &
10-
# sandbox creation times & prevents accidentally depending on this feature which may flip to off by
11-
# default in the future. Note, some rules may fail under this flag, please file issues with the rule
12-
# author.
13-
# Docs: https://bazel.build/reference/command-line-reference#flag--legacy_external_runfiles
14-
build --nolegacy_external_runfiles
15-
168
# Avoid creating a runfiles tree for binaries or tests until it is needed.
179
# Docs: https://bazel.build/reference/command-line-reference#flag--build_runfile_links
1810
# See https://github.com/bazelbuild/bazel/issues/6627

.pre-commit-config.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ repos:
1010
hooks:
1111
- id: format
1212
name: Format
13-
entry: aspect run //tools/format:format
13+
entry: bazel run //tools/format:format
1414
language: system
1515
types: [text]
1616
# Lint for starlark code.

MODULE.bazel

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
bazel_dep(name = "apple_support", version = "1.15.1")
99
bazel_dep(name = "aspect_bazel_lib", version = "2.10.0")
10-
bazel_dep(name = "aspect_rules_js", version = "2.0.0")
10+
bazel_dep(name = "aspect_rules_js", version = "2.3.6")
1111
bazel_dep(name = "aspect_rules_lint", version = "1.0.0-rc10")
1212
bazel_dep(name = "aspect_rules_py", version = "1.3.1")
1313
bazel_dep(name = "aspect_rules_swc", version = "2.0.0")
@@ -25,6 +25,7 @@ bazel_dep(name = "rules_go", version = "0.50.1")
2525
bazel_dep(name = "rules_java", version = "8.6.1")
2626
bazel_dep(name = "rules_jvm_external", version = "6.3")
2727
bazel_dep(name = "rules_multitool", version = "0.12.0")
28+
bazel_dep(name = "rules_nodejs", version = "6.3.5")
2829
bazel_dep(name = "rules_oci", version = "2.0.1")
2930
bazel_dep(name = "rules_pkg", version = "1.0.1")
3031
bazel_dep(name = "rules_proto", version = "7.1.0")
@@ -173,10 +174,8 @@ use_repo(
173174
# https://github.com/aspect-build/rules_js/tree/main/e2e/bzlmod
174175
# https://github.com/aspect-build/rules_ts/tree/main/e2e/bzlmod
175176

176-
# In keeping with the single version policy, in this example, the NPM ecosystem
177-
# dependencies are specified at the top level rather than in each sub-project.
178-
# However, it is possible to have multiple different sets of NPM dependencies
179-
# across a workspace.
177+
node = use_extension("@rules_nodejs//nodejs:extensions.bzl", "node", dev_dependency = True)
178+
node.toolchain(node_version = "20.18.0")
180179

181180
pnpm = use_extension("@aspect_rules_js//npm:extensions.bzl", "pnpm")
182181

oci_python_image/hello_world/BUILD.bazel

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,8 @@ container_structure_test(
9595
tags = [
9696
"no-remote-exec",
9797
"requires-docker",
98+
# TODO(sahin/derek?): this test passes on GitHub Actions runners but fails on AW
99+
"skip-on-aspect-workflows",
98100
],
99101
)
100102

0 commit comments

Comments
 (0)