feat: remove the ability to customize node_modules path

Fix #2196

Author: jbedard

BUILD.bazel

@@ -11,7 +11,6 @@ load("//npm:defs.bzl", "npm_link_package")
 # manual /WORKSPACE npm_import rules to bazel-bin/node_modules as well as the package store
 # bazel-bin/node_modules/.aspect_rules_js since /pnpm-lock.yaml is the root of the pnpm workspace
 npm_link_all_packages(
-    name = "node_modules",
     imported_links = [
         npm_link_acorn,
         npm_link_pnpm,
@@ -27,7 +26,6 @@ build_test(
 
 # buildifier: disable=duplicated-name
 NODE_MODULES = npm_link_targets(
-    name = "node_modules",
     package = package_name(),
 ) + [
     "//:node_modules/acorn",

docs/npm_import.md

@@ -1,5 +1,10 @@
 node_modules/
-cases/node_modules
+cases/docusaurus-direct-peer-v6/node_modules
+cases/docusaurus-direct-peer-v9/node_modules
+cases/isaacs-cliui-v90/node_modules
+cases/override-with-alias-url-v9/node_modules
+cases/tarball-no-url-v54/node_modules
+cases/versionless-patch-v9/node_modules
 projects/a/node_modules
 projects/a-types/node_modules
 projects/b/node_modules

docs/npm_link_all_packages.md

@@ -14,12 +14,12 @@ PNPM_LOCK_VERSIONS = [
 
 # Lockfiles with unique test cases
 PNPM_LOCK_TEST_CASES = [
-    "tarball-no-url-v54.yaml",
-    "override-with-alias-url-v9.yaml",
-    "isaacs-cliui-v90.yaml",
-    "docusaurus-direct-peer-v6.yaml",
-    "docusaurus-direct-peer-v9.yaml",
-    "versionless-patch-v9.yaml",
+    "tarball-no-url-v54",
+    "override-with-alias-url-v9",
+    "isaacs-cliui-v90",
+    "docusaurus-direct-peer-v6",
+    "docusaurus-direct-peer-v9",
+    "versionless-patch-v9",
 ]
 
 bazel_dep(name = "aspect_bazel_lib", version = "2.14.0")
@@ -93,8 +93,8 @@ npm = use_extension(
 
 [
     npm.npm_translate_lock(
-        name = lockfile.replace(".yaml", ""),
-        pnpm_lock = "//cases:%s" % lockfile,
+        name = lockfile,
+        pnpm_lock = "//cases/%s:pnpm-lock.yaml" % lockfile,
         verify_node_modules_ignored = "//:.bazelignore",
     )
     for lockfile in PNPM_LOCK_TEST_CASES
@@ -103,7 +103,7 @@ npm = use_extension(
 [
     use_repo(
         npm,
-        lockfile.replace(".yaml", ""),
+        lockfile,
     )
     for lockfile in PNPM_LOCK_TEST_CASES
 ]

e2e/gyp_no_install_script/snapshots/bzlmod/segfault-handler_defs.bzl

@@ -13,12 +13,12 @@ PNPM_LOCK_VERSIONS = [
 
 # Lockfiles with unique test cases
 PNPM_LOCK_TEST_CASES = [
-    "tarball-no-url-v54.yaml",
-    "override-with-alias-url-v9.yaml",
-    "isaacs-cliui-v90.yaml",
-    "docusaurus-direct-peer-v6.yaml",
-    "docusaurus-direct-peer-v9.yaml",
-    "versionless-patch-v9.yaml",
+    "tarball-no-url-v54",
+    "override-with-alias-url-v9",
+    "isaacs-cliui-v90",
+    "docusaurus-direct-peer-v6",
+    "docusaurus-direct-peer-v9",
+    "versionless-patch-v9",
 ]
 
 load("@aspect_rules_js//js:repositories.bzl", "rules_js_dependencies")
@@ -59,8 +59,8 @@ npm_repositories_v90()
 
 [
     npm_translate_lock(
-        name = lockfile.replace(".yaml", ""),
-        pnpm_lock = "//cases:%s" % lockfile,
+        name = lockfile,
+        pnpm_lock = "//cases/%s:pnpm-lock.yaml" % lockfile,
         verify_node_modules_ignored = "//:.bazelignore",
     )
     for lockfile in PNPM_LOCK_TEST_CASES