Skip to content

Commit 716717a

Browse files
committed
fix: npm_translate_lock(exclude_package_contents["*"]) should only be a fallback if no explicit package found
1 parent 0b21e0b commit 716717a

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

npm/private/npm_translate_lock_helpers.bzl

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ def _gather_package_content_excludes(keyed_lists, *names):
5252
keys = []
5353
result = {}
5454
for name in names:
55-
if name and (name in keyed_lists or "*" in keyed_lists):
55+
if name in keyed_lists:
5656
keys.append(name)
5757
v = keyed_lists[name] if name in keyed_lists else keyed_lists["*"]
5858
if type(v) == "list":
@@ -65,6 +65,8 @@ def _gather_package_content_excludes(keyed_lists, *names):
6565

6666
# in case the key has not been met even once, we return None, instead of empty list as empty list is a valid value
6767
if not keys:
68+
if "*" in keyed_lists:
69+
return keyed_lists["*"] if type(keyed_lists["*"]) == "list" else [keyed_lists["*"]]
6870
return None
6971

7072
return result.keys()

0 commit comments

Comments
 (0)