feat: remove the ability to customize node_modules path

Fix #2196

Author: jbedard

BUILD.bazel

@@ -11,7 +11,6 @@ load("//npm:defs.bzl", "npm_link_package")
 # manual /WORKSPACE npm_import rules to bazel-bin/node_modules as well as the package store
 # bazel-bin/node_modules/.aspect_rules_js since /pnpm-lock.yaml is the root of the pnpm workspace
 npm_link_all_packages(
-    name = "node_modules",
     imported_links = [
         npm_link_acorn,
         npm_link_pnpm,
@@ -27,7 +26,6 @@ build_test(
 
 # buildifier: disable=duplicated-name
 NODE_MODULES = npm_link_targets(
-    name = "node_modules",
     package = package_name(),
 ) + [
     "//:node_modules/acorn",

docs/npm_import.md

@@ -93,7 +93,7 @@ npm = use_extension(
 
 [
     npm.npm_translate_lock(
-        name = lockfile.replace(".yaml", ""),
+        name = lockfile,
         pnpm_lock = "//cases/%s:pnpm-lock.yaml" % lockfile,
         verify_node_modules_ignored = "//:.bazelignore",
     )
@@ -103,7 +103,7 @@ npm = use_extension(
 [
     use_repo(
         npm,
-        lockfile.replace(".yaml", ""),
+        lockfile,
     )
     for lockfile in PNPM_LOCK_TEST_CASES
 ]

docs/npm_link_all_packages.md

@@ -59,7 +59,7 @@ npm_repositories_v90()
 
 [
     npm_translate_lock(
-        name = lockfile.replace(".yaml", ""),
+        name = lockfile,
         pnpm_lock = "//cases/%s:pnpm-lock.yaml" % lockfile,
         verify_node_modules_ignored = "//:.bazelignore",
     )

e2e/gyp_no_install_script/snapshots/bzlmod/segfault-handler_defs.bzl

@@ -45,7 +45,7 @@ def lockfile_test(npm_link_all_packages, name = None):
     lock_version = name if name else native.package_name()
     lock_repo = "lock-%s" % lock_version
 
-    npm_link_all_packages(name = "node_modules")
+    npm_link_all_packages()
 
     # Copy each test to this lockfile dir
     for test in ["patched-dependencies-test.js", "aliases-test.js"]:
@@ -134,8 +134,8 @@ def lockfile_test(npm_link_all_packages, name = None):
 
             # Packages involving overrides
             ":node_modules/is-odd",
-            ":.aspect_rules_js/node_modules/[email protected]",
-            ":.aspect_rules_js/node_modules/[email protected]",
+            ":.aspect_rules_js/[email protected]",
+            ":.aspect_rules_js/[email protected]",
 
             # Odd git/http versions
             ":node_modules/debug",
@@ -162,46 +162,46 @@ def lockfile_test(npm_link_all_packages, name = None):
             ":node_modules/is-odd-v1",
             ":node_modules/is-odd-v2",
             ":node_modules/is-odd-v3",
-            ":.aspect_rules_js/node_modules/[email protected]",
-            ":.aspect_rules_js/node_modules/[email protected]",
-            ":.aspect_rules_js/node_modules/[email protected]",
-            ":.aspect_rules_js/node_modules/[email protected]",
+            ":.aspect_rules_js/[email protected]",
+            ":.aspect_rules_js/[email protected]",
+            ":.aspect_rules_js/[email protected]",
+            ":.aspect_rules_js/[email protected]",
 
             # npm: alias to package not listed elsewhere
             ":node_modules/alias-only-sizzle",
-            ":.aspect_rules_js/node_modules/@[email protected]",
+            ":.aspect_rules_js/@[email protected]",
             "@%s__at_types_sizzle__2.3.9//:pkg" % lock_repo,
 
             # Targets within the virtual store...
             # Direct dep targets
-            ":.aspect_rules_js/node_modules/@[email protected]",
-            ":.aspect_rules_js/node_modules/@[email protected]/dir",
-            ":.aspect_rules_js/node_modules/@[email protected]/pkg",
-            ":.aspect_rules_js/node_modules/@[email protected]/ref",
+            ":.aspect_rules_js/@[email protected]",
+            ":.aspect_rules_js/@[email protected]/dir",
+            ":.aspect_rules_js/@[email protected]/pkg",
+            ":.aspect_rules_js/@[email protected]/ref",
 
             # Direct deps with lifecycles
-            ":.aspect_rules_js/node_modules/@[email protected]/lc",
-            ":.aspect_rules_js/node_modules/@[email protected]/pkg_lc",
+            ":.aspect_rules_js/@[email protected]/lc",
+            ":.aspect_rules_js/@[email protected]/pkg_lc",
 
             # link:, workspace:, file:, ./rel/path
-            ":.aspect_rules_js/node_modules/@[email protected]",
-            ":.aspect_rules_js/node_modules/@[email protected]",
-            ":.aspect_rules_js/node_modules/@[email protected]",
-            ":.aspect_rules_js/node_modules/@[email protected]",
-            ":.aspect_rules_js/node_modules/[email protected]",
-            ":.aspect_rules_js/node_modules/[email protected]",
-            ":.aspect_rules_js/node_modules/[email protected]",
-            ":.aspect_rules_js/node_modules/[email protected]/dir",
+            ":.aspect_rules_js/@[email protected]",
+            ":.aspect_rules_js/@[email protected]",
+            ":.aspect_rules_js/@[email protected]",
+            ":.aspect_rules_js/@[email protected]",
+            ":.aspect_rules_js/[email protected]",
+            ":.aspect_rules_js/[email protected]",
+            ":.aspect_rules_js/[email protected]",
+            ":.aspect_rules_js/[email protected]/dir",
 
             # Patched dependencies
-            ":.aspect_rules_js/node_modules/[email protected]_o3deharooos255qt5xdujc3cuq",
+            ":.aspect_rules_js/[email protected]_o3deharooos255qt5xdujc3cuq",
             "@%s__meaning-of-life__1.0.0_o3deharooos255qt5xdujc3cuq//:pkg" % lock_repo,
 
             # Direct deps from custom registry
-            ":.aspect_rules_js/node_modules/@[email protected]",
+            ":.aspect_rules_js/@[email protected]",
 
             # Direct deps with peers
-            ":.aspect_rules_js/node_modules/@[email protected]_at_aspect-test_c_2.0.2",
+            ":.aspect_rules_js/@[email protected]_at_aspect-test_c_2.0.2",
             "@%s__at_aspect-test_d__2.0.0_at_aspect-test_c_2.0.2//:pkg" % lock_repo,
         ],
     )