[Bug]: No longer able to reference js_library's after https://github.com/aspect-build/rules_js/pull/1850

[jrandolf]

What happened?

Before #1850, js_library was linked automatically and could be referenced as :node_modules/package_name. This no longer works.

Version

Development (host) and target OS/architectures: N/A

Output of bazel --version: N/A

Version of the Aspect rules, or other relevant rules from your
WORKSPACE or MODULE.bazel file: N/A

Language(s) and/or frameworks involved: JS/TS

How to reproduce

No response

Any other information?

No response

[jrandolf]

After some debugging, it looks like package.jsons of linked packages are missing at build times if specified in the srcs attribute of js_library.

[jbedard]

Have you found a way to workaround this? Using js_library seems to work fine everywhere I've used it so you must have a more specific issue happening here?

[jrandolf]

The workaround is the attached PR, but as you've written in the PR, it can probably be written better.

The issue arises when the javascript files in a js_library require the package.json to be interpreted. To be precise, if you don't use .mjs or .cjs, Node determines the JS file as cjs unless either (1) the es cli flag is enabled or (2) the package.json says the package is of type "module". In the latter case, js_library does carry the information if you add it as a srcs dependency, but when you try to use a dependency targeting (e.g. :node_modules:library-name) instead of direct targets (e.g. //path/to:library-name, the package.json gets lost for some reason.

[jbedard]

I've see that used in several repositories and it seems to work fine though so there must be something unique you're doing. You'll have to reproduce it in a test to show what's going on here.