Skip to content

feat: add default npm package excludes from yarn #2136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: add default npm package excludes from yarn #2136

wants to merge 3 commits into from

Conversation

Mivr
Copy link
Contributor

@Mivr Mivr commented Mar 19, 2025 •
edited by jbedard
Loading

Closes #2110

Changes are visible to end-users: yes

  • Searched for relevant documentation and updated as needed: yes
  • Breaking change (forces users to change their own code or config): yes
  • Suggested release notes appear below: yes

Added default package contents exclusion similar to yarn default exclusion.

Test plan

  • Covered by existing test cases

@aspect-workflows Aspect Workflows
Copy link

aspect-workflows bot commented Mar 19, 2025 •
edited
Loading

Test

All tests were cache hits

218 tests (100.0%) were fully cached saving 31s.

Test

e2e/bzlmod

All tests were cache hits

5 tests (100.0%) were fully cached saving 550ms.

Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 136ms.

Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 12s.

Test

e2e/npm_link_package

All tests were cache hits

3 tests (100.0%) were fully cached saving 484ms.

Test

e2e/npm_link_package-esm

All tests were cache hits

3 tests (100.0%) were fully cached saving 502ms.

Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 30ms.

Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 30ms.

Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 268ms.

Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.

Test

e2e/npm_translate_lock_replace_packages

All tests were cache hits

3 tests (100.0%) were fully cached saving 603ms.

Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 76ms.

Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.

Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.

Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 273ms.

Test

e2e/pnpm_lockfiles

All tests were cache hits

42 tests (100.0%) were fully cached saving 2s.

Test

e2e/pnpm_workspace

All tests were cache hits

10 tests (100.0%) were fully cached saving 2s.

Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

12 tests (100.0%) were fully cached saving 2s.

Test

e2e/repo_mapping

All tests were cache hits

3 tests (100.0%) were fully cached saving 483ms.

Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 138ms.

Test

e2e/runfiles

All tests were cache hits

1 test (100.0%) was fully cached saving 140ms.

Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 99ms.

Buildifier      Format

jbedard
jbedard reviewed Mar 19, 2025
View reviewed changes
npm/private/exclude_package_contents_default.bzl Outdated
@@ -0,0 +1,49 @@
"A default files exclude list for common packages."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets document where this list came from, probably just a link to the yarn docs and/or code?

@jbedard jbedard requested review from jbedard and alexeagle March 19, 2025 19:00
@jbedard jbedard mentioned this pull request Apr 2, 2025
Merged
@jbedard jbedard changed the title [FR]: Add default npm package excludes from yarn feat: add default npm package excludes from yarn Apr 4, 2025
@jbedard jbedard mentioned this pull request Apr 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbedard jbedard Awaiting requested review from jbedard

@alexeagle alexeagle Awaiting requested review from alexeagle

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FR]: provide default exclude_package_contents similar to yarn autoclean
3 participants
@Mivr @jbedard @alexeagle