Skip to content

Remove ability to customize virtual store name #2196

Open
@jbedard

Description

@jbedard

Today npm_link_all_packages(name) can be used to specify:

  • the link_root_name in .aspect_rules_js/{link_root_name}/package_key
  • the :{link_root_name}/package_name

This allows multiple npm repositories (lockfiles) to be linked into the same directory - multiple npm_link_all_packages invocations in the same BUILD. This feature is most likely never or rarely used, yet causes many strings to be constructed dynamically.

Metadata

Metadata

Assignees

Labels

breakingRequires a semver-major release due to breaking public API changes

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions