Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will upgrade in handlebars cause any issues with current grunt assemble module #70

Open
pravinweb opened this issue Dec 14, 2020 · 2 comments

Comments

@pravinweb
Copy link

Dear team,

Below is my package json of project

"dependencies": {
    "grunt": "0.4.5",
    "grunt-assemble": "^0.5.0",
    "grunt-assemble-permalinks": "0.1.0"
    "handlebars": "3.0.3"
}

I want to upgrade handlebars to latest one - 4.7.6 in this case do I need to upgrade "grunt-assemble": "^0.5.0" package as well to "grunt-assemble": "^0.6.3" ? or would it be fine if I keep "grunt-assemble": "^0.5.0" as it is ?

Note: I am using npm-shrinkwrap.json to manage versions

@assemblebot
Copy link

@pravinweb Thanks for the issue! If you're reporting a bug, please be sure to include:

  • The version of assemble you are using.
  • Your assemblefile.js (This can be in a gist)
  • The commandline output. (Screenshot or gist is fine)
  • What you expected to happen instead.

@kdekooter
Copy link

kdekooter commented Jan 20, 2021

grunt-assemble:0.6.3 uses assemble-handlebars:0.4.1 which uses "handlebars": "^4.0.6".

Maybe 4.0.6 is enough of a bump up for you? In that case an upgrade to grunt-assemble:0.6.3 would be sufficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants