refactor(RM): move install_simple_trigger

Moves `install_simple_trigger` to `exandra` and `ecto`

Signed-off-by: Luca Zaninotto <luca.zaninotto@secomind.com>

Author: lusergit

apps/astarte_realm_management/lib/astarte_realm_management/astarte/kv_store.ex

@@ -53,6 +53,16 @@ defmodule Astarte.RealmManagement.Astarte.KvStore do
           Keyword.t()
         ) :: :ok | {:error, Exception.t()}
   def insert(kv_store_map, opts \\ []) do
+    {keyspace, opts} = Keyword.pop!(opts, :prefix)
+
+    {sql, params} = insert_sql(kv_store_map, keyspace)
+
+    with {:ok, _} <- Repo.query(sql, params, opts) do
+      :ok
+    end
+  end
+
+  def insert_sql(kv_store_map, keyspace) do
     %{
       group: group,
       key: key,
@@ -69,8 +79,6 @@ defmodule Astarte.RealmManagement.Astarte.KvStore do
         :string -> "varcharAsBlob(?)"
       end
 
-    {keyspace, opts} = Keyword.pop!(opts, :prefix)
-
     sql =
       """
         INSERT INTO #{keyspace}.#{@source} (group, key, value)
@@ -79,9 +87,7 @@ defmodule Astarte.RealmManagement.Astarte.KvStore do
 
     params = [group, key, value]
 
-    with {:ok, _} <- Repo.query(sql, params, opts) do
-      :ok
-    end
+    {sql, params}
   end
 
   @spec fetch_value(String.t(), String.t(), value_type(), Keyword.t()) ::

apps/astarte_realm_management/lib/astarte_realm_management/engine.ex

@@ -508,7 +508,8 @@ defmodule Astarte.RealmManagement.Engine do
          t_container = build_trigger_target_container(trigger_target),
          :ok <- validate_simple_triggers(realm_name, simple_trigger_maps),
          # TODO: these should be batched together
-         :ok <- install_simple_triggers(client, simple_trigger_maps, trigger_uuid, t_container),
+         :ok <-
+           install_simple_triggers(realm_name, simple_trigger_maps, trigger_uuid, t_container),
          :ok <- install_trigger_policy_link(client, trigger_uuid, trigger_policy_name, realm_name) do
       _ =
         Logger.info("Installing trigger.",
@@ -672,7 +673,7 @@ defmodule Astarte.RealmManagement.Engine do
     end
   end
 
-  defp install_simple_triggers(client, simple_trigger_maps, trigger_uuid, trigger_target) do
+  defp install_simple_triggers(realm_name, simple_trigger_maps, trigger_uuid, trigger_target) do
     Enum.reduce_while(simple_trigger_maps, :ok, fn
       simple_trigger_map, _acc ->
         %{
@@ -683,7 +684,7 @@ defmodule Astarte.RealmManagement.Engine do
         } = simple_trigger_map
 
         case Queries.install_simple_trigger(
-               client,
+               realm_name,
                object_id,
                object_type,
                trigger_uuid,

apps/astarte_realm_management/lib/astarte_realm_management/queries.ex

@@ -920,52 +920,57 @@ defmodule Astarte.RealmManagement.Queries do
   end
 
   def install_simple_trigger(
-        client,
+        realm_name,
         object_id,
         object_type,
         parent_trigger_id,
         simple_trigger_id,
         simple_trigger,
         trigger_target
       ) do
+    keyspace = Realm.keyspace_name(realm_name)
+
     insert_simple_trigger_statement = """
-    INSERT INTO simple_triggers
+    INSERT INTO #{keyspace}.simple_triggers
     (object_id, object_type, parent_trigger_id, simple_trigger_id, trigger_data, trigger_target)
-    VALUES (:object_id, :object_type, :parent_trigger_id, :simple_trigger_id, :simple_trigger_data, :trigger_target_data);
+    VALUES (?, ?, ?, ?, ?, ?);
     """
 
-    insert_simple_trigger_query =
-      DatabaseQuery.new()
-      |> DatabaseQuery.statement(insert_simple_trigger_statement)
-      |> DatabaseQuery.put(:object_id, object_id)
-      |> DatabaseQuery.put(:object_type, object_type)
-      |> DatabaseQuery.put(:parent_trigger_id, parent_trigger_id)
-      |> DatabaseQuery.put(:simple_trigger_id, simple_trigger_id)
-      |> DatabaseQuery.put(:simple_trigger_data, SimpleTriggerContainer.encode(simple_trigger))
-      |> DatabaseQuery.put(:trigger_target_data, TriggerTargetContainer.encode(trigger_target))
-
-    astarte_ref = %AstarteReference{
-      object_type: object_type,
-      object_uuid: object_id
-    }
-
-    insert_simple_trigger_by_uuid_statement =
-      "INSERT INTO kv_store (group, key, value) VALUES ('simple-triggers-by-uuid', :simple_trigger_id, :astarte_ref);"
+    insert_params = [
+      object_id,
+      object_type,
+      parent_trigger_id,
+      simple_trigger_id,
+      SimpleTriggerContainer.encode(simple_trigger),
+      TriggerTargetContainer.encode(trigger_target)
+    ]
 
-    insert_simple_trigger_by_uuid_query =
-      DatabaseQuery.new()
-      |> DatabaseQuery.statement(insert_simple_trigger_by_uuid_statement)
-      |> DatabaseQuery.put(:simple_trigger_id, :uuid.uuid_to_string(simple_trigger_id))
-      |> DatabaseQuery.put(:astarte_ref, AstarteReference.encode(astarte_ref))
+    astarte_ref =
+      %AstarteReference{
+        object_type: object_type,
+        object_uuid: object_id
+      }
+      |> AstarteReference.encode()
+
+    simple_trigger_id =
+      simple_trigger_id
+      |> :uuid.uuid_to_string()
+      |> to_string()
+
+    kv_insert =
+      %{
+        group: "simple-triggers-by-uuid",
+        key: simple_trigger_id,
+        value: astarte_ref
+      }
+      |> KvStore.insert_sql(keyspace)
 
-    with {:ok, _res} <- DatabaseQuery.call(client, insert_simple_trigger_query),
-         {:ok, _res} <- DatabaseQuery.call(client, insert_simple_trigger_by_uuid_query) do
-      :ok
-    else
-      not_ok ->
-        _ = Logger.warning("Database error: #{inspect(not_ok)}.", tag: "db_error")
-        {:error, :cannot_install_simple_trigger}
-    end
+    Exandra.execute_batch(
+      Repo,
+      %Exandra.Batch{
+        queries: [{insert_simple_trigger_statement, insert_params}, kv_insert]
+      }
+    )
   end
 
   def install_trigger_policy_link(_client, _trigger_uuid, nil) do