refactor(appengine): port Device.insert_alias to exandra

the insert was left as-is, while for the update Repo.to_sql was used

Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>

Author: noaccOS

apps/astarte_appengine_api/lib/astarte_appengine_api/device/queries.ex

@@ -597,46 +597,35 @@ defmodule Astarte.AppEngine.API.Device.Queries do
   end
 
   def insert_alias(realm_name, client, device_id, alias_tag, alias_value) do
+    keyspace = keyspace_name(realm_name)
+    names_table = Name.__schema__(:source)
+
     insert_alias_to_names_statement = """
-    INSERT INTO names
+    INSERT INTO #{keyspace}.#{names_table}
     (object_name, object_type, object_uuid)
-    VALUES (:alias, 1, :device_id)
+    VALUES (?, 1, ?)
     """
 
-    insert_alias_to_names_query =
-      DatabaseQuery.new()
-      |> DatabaseQuery.statement(insert_alias_to_names_statement)
-      |> DatabaseQuery.put(:alias, alias_value)
-      |> DatabaseQuery.put(:device_id, device_id)
-      |> DatabaseQuery.consistency(:each_quorum)
-      |> DatabaseQuery.convert()
+    insert_alias_to_names_params = [alias_value, device_id]
+    insert_alias_to_names_query = {insert_alias_to_names_statement, insert_alias_to_names_params}
 
-    insert_alias_to_device_statement = """
-    UPDATE devices
-    SET aliases[:alias_tag] = :alias
-    WHERE device_id = :device_id
-    """
+    new_alias = %{alias_tag => alias_value}
 
-    insert_alias_to_device_query =
-      DatabaseQuery.new()
-      |> DatabaseQuery.statement(insert_alias_to_device_statement)
-      |> DatabaseQuery.put(:alias_tag, alias_tag)
-      |> DatabaseQuery.put(:alias, alias_value)
-      |> DatabaseQuery.put(:device_id, device_id)
-      |> DatabaseQuery.consistency(:each_quorum)
-      |> DatabaseQuery.convert()
+    insert_alias_to_device =
+      from DatabaseDevice,
+        prefix: ^keyspace,
+        where: [device_id: ^device_id],
+        update: [set: [aliases: fragment("aliases + ?", ^new_alias)]]
+
+    insert_alias_to_device_query = Repo.to_sql(:update_all, insert_alias_to_device)
 
     insert_batch =
-      CQEx.cql_query_batch(
-        consistency: :each_quorum,
-        mode: :logged,
-        queries: [insert_alias_to_names_query, insert_alias_to_device_query]
-      )
+      %Exandra.Batch{queries: [insert_alias_to_names_query, insert_alias_to_device_query]}
 
     with {:existing, {:error, :device_not_found}} <-
            {:existing, device_alias_to_device_id(realm_name, alias_value)},
          :ok <- try_delete_alias(realm_name, client, device_id, alias_tag),
-         {:ok, _result} <- DatabaseQuery.call(client, insert_batch) do
+         :ok <- Exandra.execute_batch(Repo, insert_batch, consistency: :each_quorum) do
       :ok
     else
       {:existing, {:ok, _device_uuid}} ->
@@ -647,14 +636,6 @@ defmodule Astarte.AppEngine.API.Device.Queries do
 
       {:error, :device_not_found} ->
         {:error, :device_not_found}
-
-      %{acc: _, msg: error_message} ->
-        _ = Logger.warning("Database error: #{error_message}.", tag: "db_error")
-        {:error, :database_error}
-
-      {:error, reason} ->
-        _ = Logger.warning("Database error, reason: #{inspect(reason)}.", tag: "db_error")
-        {:error, :database_error}
     end
   end