refactor(RM): move intall_trigger_policy

Moved `install_trigger_policy` to `exandra` and `ecto`

Signed-off-by: Luca Zaninotto <luca.zaninotto@secomind.com>

Author: lusergit

apps/astarte_realm_management/lib/astarte_realm_management/astarte/kv_store.ex

@@ -77,6 +77,7 @@ defmodule Astarte.RealmManagement.Astarte.KvStore do
         :integer -> "intAsBlob(?)"
         :big_integer -> "bigintAsBlob(?)"
         :string -> "varcharAsBlob(?)"
+        :uuid -> "uuidAsBlob(?)"
       end
 
     sql =

apps/astarte_realm_management/lib/astarte_realm_management/engine.ex

@@ -510,7 +510,8 @@ defmodule Astarte.RealmManagement.Engine do
          # TODO: these should be batched together
          :ok <-
            install_simple_triggers(realm_name, simple_trigger_maps, trigger_uuid, t_container),
-         :ok <- install_trigger_policy_link(client, trigger_uuid, trigger_policy_name, realm_name) do
+         :ok <-
+           install_trigger_policy_link(realm_name, trigger_uuid, trigger_policy_name) do
       _ =
         Logger.info("Installing trigger.",
           trigger_name: trigger_name,
@@ -701,17 +702,17 @@ defmodule Astarte.RealmManagement.Engine do
     end)
   end
 
-  defp install_trigger_policy_link(_client, _trigger_uuid, nil, _realm_name) do
+  defp install_trigger_policy_link(_realm_name, _trigger_uuid, nil) do
     :ok
   end
 
-  defp install_trigger_policy_link(_client, _trigger_uuid, "", _realm_name) do
+  defp install_trigger_policy_link(_realm_name, _trigger_uuid, "") do
     :ok
   end
 
-  defp install_trigger_policy_link(client, trigger_uuid, trigger_policy_name, realm_name) do
+  defp install_trigger_policy_link(realm_name, trigger_uuid, trigger_policy_name) do
     with :ok <- verify_trigger_policy_exists(realm_name, trigger_policy_name) do
-      Queries.install_trigger_policy_link(client, trigger_uuid, trigger_policy_name)
+      Queries.install_trigger_policy_link(realm_name, trigger_uuid, trigger_policy_name)
     end
   end
 

apps/astarte_realm_management/lib/astarte_realm_management/queries.ex

@@ -961,33 +961,32 @@ defmodule Astarte.RealmManagement.Queries do
     :ok
   end
 
-  def install_trigger_policy_link(client, trigger_uuid, trigger_policy) do
-    insert_trigger_with_policy_statement =
-      "INSERT INTO kv_store (group, key, value) VALUES (:policy_group, :trigger_uuid, uuidAsBlob(:t_uuid_to_be_converted))"
+  def install_trigger_policy_link(realm_name, trigger_uuid, trigger_policy) do
+    keyspace = Realm.keyspace_name(realm_name)
 
-    insert_trigger_with_policy_query =
-      DatabaseQuery.new()
-      |> DatabaseQuery.statement(insert_trigger_with_policy_statement)
-      |> DatabaseQuery.put(:policy_group, "triggers-with-policy-#{trigger_policy}")
-      |> DatabaseQuery.put(:trigger_uuid, :uuid.uuid_to_string(trigger_uuid))
-      |> DatabaseQuery.put(:t_uuid_to_be_converted, :uuid.uuid_to_string(trigger_uuid))
+    trigger_uuid =
+      trigger_uuid
+      |> :uuid.uuid_to_string()
+      |> to_string()
 
-    insert_trigger_to_policy_statement =
-      "INSERT INTO kv_store (group, key, value) VALUES ('trigger_to_policy',  :trigger_uuid, :trigger_policy);"
+    triggers_with_policy =
+      %{
+        group: "triggers-with-policy-#{trigger_policy}",
+        key: trigger_uuid,
+        value: trigger_uuid,
+        value_type: :uuid
+      }
 
-    insert_trigger_to_policy_query =
-      DatabaseQuery.new()
-      |> DatabaseQuery.statement(insert_trigger_to_policy_statement)
-      |> DatabaseQuery.put(:trigger_uuid, :uuid.uuid_to_string(trigger_uuid))
-      |> DatabaseQuery.put(:trigger_policy, trigger_policy)
+    trigger_to_policy =
+      %{
+        group: "trigger_to_policy",
+        key: trigger_uuid,
+        value: trigger_policy
+      }
 
-    with {:ok, _result} <- DatabaseQuery.call(client, insert_trigger_with_policy_query),
-         {:ok, _result} <- DatabaseQuery.call(client, insert_trigger_to_policy_query) do
+    with :ok <- KvStore.insert(triggers_with_policy, prefix: keyspace),
+         :ok <- KvStore.insert(trigger_to_policy, prefix: keyspace) do
       :ok
-    else
-      not_ok ->
-        _ = Logger.warning("Database error: #{inspect(not_ok)}.", tag: "db_error")
-        {:error, :cannot_install_trigger_policy_link}
     end
   end