Add missing ir-to-Julia conversions and add tests

Author: asterycs

src/ir.jl

@@ -131,6 +131,10 @@ function _get_variables(arg::Cos)
     return _get_variables(arg.arg)
 end
 
+function _get_variables(arg::Log)
+    return _get_variables(arg.arg)
+end
+
 function _get_variables(arg::Add)
     return [_get_variables(arg.l); _get_variables(arg.r)]
 end

src/julia.jl

@@ -43,6 +43,10 @@ function to_julia(arg::ir.Cos)
     return :(cos.($(to_julia(arg.arg))))
 end
 
+function to_julia(arg::ir.Log)
+    return :(log.($(to_julia(arg.arg))))
+end
+
 function to_julia(arg::ir.Add)
     return :($(to_julia(arg.l)) + $(to_julia(arg.r)))
 end

test/JuliaTest.jl

@@ -1,10 +1,10 @@
 using ForwardDiff
 
-using LinearAlgebra: diagm, I
+using LinearAlgebra: tr, diagm, I
 
 @testset "test Julia function" begin
     @matrix A B C
-    @vector x y
+    @vector x y z
 
     x̂ = [
         0.055
@@ -18,6 +18,12 @@ using LinearAlgebra: diagm, I
         0.176
     ]
 
+    ẑ = [
+        0.578
+        0.845
+        0.711
+    ]
+
     Â = [
         0.023 0.136 0.181
         0.443 0.132 0.576
@@ -36,6 +42,24 @@ using LinearAlgebra: diagm, I
         0.415 0.483 0.969
     ]
 
+    @testset "function tr(x*x')" begin
+        jfun = eval(to_std(tr(x*x'); format = dc.JuliaFunc()))
+
+        @test jfun(x̂) ≈ tr(x̂*x̂')
+    end
+
+    @testset "function tr(A*B'*C)" begin
+        jfun = eval(to_std(tr(A*B'*C); format = dc.JuliaFunc()))
+
+        @test jfun(B̂, Ĉ, Â) ≈ tr(Â * B̂' * Ĉ)
+    end
+
+    @testset "function log(A' * x)" begin
+        jfun = eval(to_std(log.(A' * x); format = dc.JuliaFunc()))
+
+        @test jfun(Â, x̂) ≈ log.(Â' * x̂)
+    end
+
     @testset "gradient of x'*x" begin
         jgrad = eval(to_std(gradient(x' * x, x); format = dc.JuliaFunc()))
 
@@ -54,10 +78,10 @@ using LinearAlgebra: diagm, I
         @test jgrad(x̂) ≈ ForwardDiff.gradient(x -> cos(tr(x * x')), x̂)
     end
 
-    @testset "jacobian of sin(A * x + y)" begin
-        jjac = eval(to_std(jacobian(sin.(A * x + y), x); format = dc.JuliaFunc()))
+    @testset "jacobian of sin(A * x + y - z)" begin
+        jjac = eval(to_std(jacobian(sin.(A * x + y - z), x); format = dc.JuliaFunc()))
 
-        @test jjac(Â, x̂, ŷ) ≈ ForwardDiff.jacobian(x -> sin.(Â * x + ŷ), x̂)
+        @test jjac(Â, x̂, ŷ, ẑ) ≈ ForwardDiff.jacobian(x -> sin.(Â * x + ŷ - ẑ), x̂)
     end
 
     @testset "jacobian of (A .* B) * C * x)' * x * x" begin