Skip to content

Commit 8ede57c

Browse files
committed
be more encouraging :)
1 parent 6d233e1 commit 8ede57c

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed

scripts/conformance.py

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -783,11 +783,18 @@ def fmt(old: int, new: int, *, greater_is_better: bool = True) -> str:
783783
if fs.new_passes and not fs.old_passes:
784784
status = "✅ Newly Passing 🎉"
785785
elif fs.old_passes and not fs.new_passes:
786-
status = "❌ Regressed"
786+
status = "❌ Newly Failing"
787787
elif fs.new_passes:
788788
status = "✅"
789789
else:
790-
status = "❌"
790+
old_errors = fs.old.false_positives + fs.old.false_negatives
791+
new_errors = fs.new.false_positives + fs.new.false_negatives
792+
if new_errors < old_errors:
793+
status = "📈 Improving"
794+
elif new_errors > old_errors:
795+
status = "📉 Regressing"
796+
else:
797+
status = "➡️ Neutral"
791798
url = CONFORMANCE_DIR_WITH_README + f"tests/{fs.path.name}"
792799
rows.append(
793800
f"| [{fs.path.name}]({url})"

0 commit comments

Comments
 (0)