Avoid clone

Author: charliermarsh

crates/ty_python_semantic/src/semantic_index/builder.rs

@@ -812,9 +812,14 @@ impl<'db, 'ast> SemanticIndexBuilder<'db, 'ast> {
             }
         }
 
-        let snapshot = self.use_def_maps[scope].snapshot();
-        self.try_node_context_stack_manager
-            .record_definition(scope_index, &snapshot);
+        if self
+            .try_node_context_stack_manager
+            .has_active_try_context(scope_index)
+        {
+            let snapshot = self.use_def_maps[scope].snapshot();
+            self.try_node_context_stack_manager
+                .record_definition(scope_index, &snapshot);
+        }
 
         (definition, num_definitions)
     }

crates/ty_python_semantic/src/semantic_index/builder/except_handlers.rs

@@ -37,6 +37,14 @@ impl TryNodeContextStackManager {
         self.current_try_context_stack().pop_context()
     }
 
+    /// Returns `true` if the scope at `scope_index` is currently inside at least
+    /// one `try` block and therefore needs definition snapshots recorded.
+    pub(super) fn has_active_try_context(&self, scope_index: usize) -> bool {
+        self.0
+            .get(scope_index)
+            .is_some_and(|stack| !stack.0.is_empty())
+    }
+
     /// Record a definition in the try-node context at `scope_index`.
     ///
     /// For each active `try` block in that scope's context stack, a clone of `snapshot`