Skip to content

Commit 3072810

Browse files
zaniebclaude
andauthored
Allow releases to continue on failure to publish to crates.io (#19291)
Alas this job can fail and retries cannot be performed --------- Co-authored-by: Claude <noreply@anthropic.com>
1 parent 2efecda commit 3072810

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

.github/workflows/release.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,9 @@ jobs:
311311
# use "always() && ..." to allow us to wait for all publish jobs while
312312
# still allowing individual publish jobs to skip themselves (for prereleases).
313313
# "host" however must run to completion, no skipping allowed!
314-
if: ${{ always() && needs.host.result == 'success' && needs.release-gate.result == 'success' && (needs.custom-publish-pypi.result == 'skipped' || needs.custom-publish-pypi.result == 'success') && (needs.custom-publish-crates.result == 'skipped' || needs.custom-publish-crates.result == 'success') }}
314+
# `custom-publish-crates` is intentionally not gated on its result: it's
315+
# not critical to the release and isn't idempotent on retry.
316+
if: ${{ always() && needs.host.result == 'success' && needs.release-gate.result == 'success' && (needs.custom-publish-pypi.result == 'skipped' || needs.custom-publish-pypi.result == 'success') }}
315317
runs-on: "depot-ubuntu-latest-4"
316318
environment:
317319
name: release

0 commit comments

Comments
 (0)